Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EnhancedSwitch] added inputStyle prop to enhanced switch #1693

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

pbambusek
Copy link
Contributor

Allows overriding styles of backing input element. Having position: absolute by default doesn't always play nicely with surrounding elements.

@oliviertassinari
Copy link
Member

Looks good. Can you add inputStyle to the documentation and rebase?

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Oct 26, 2015
@mbrookes
Copy link
Member

mbrookes commented Feb 4, 2016

@pbambusek?

@pbambusek
Copy link
Contributor Author

rebased & updated

I'm not sure how you solve propTypes for docs when there is hierarchy of components, so I've added it to all switches.

@oliviertassinari oliviertassinari added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: Needs Review labels Feb 4, 2016
oliviertassinari added a commit that referenced this pull request Feb 5, 2016
[EnhancedSwitch] added inputStyle prop to enhanced switch
@oliviertassinari oliviertassinari merged commit 4206458 into mui:master Feb 5, 2016
@oliviertassinari
Copy link
Member

@pbambusek Thanks!

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* Rename KeyboardIcon to CalendarIcon

The icon components should be named after their content.

* Rename `keyboardIcon` prop to `openPickerIcon` mui#1693

The prop should be named after the icon's functionality/usage. The new name matches the `hideOpenPickerButton` prop. The documentation on the prop already matches this wording. Tested by verifying that the two affected demo pages still work and show the customized icon.

* Update lib/src/_shared/icons/CalendarIcon.tsx

Co-Authored-By: Olivier Tassinari <[email protected]>

Co-authored-by: Dmitriy Kovalenko <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
@zannager zannager added component: switch This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: switch This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants