-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update themes.jsx #1696
Update themes.jsx #1696
Conversation
@EcutDavid we're going to release v0.12 soon and it would probably be a good idea to put this there (since v0.12 deals with theme changes). Do you mind submitting this PR to the v0.12 branch instead? |
@shaurya947 Ok :) |
@EcutDavid we merged v0.12 into master so I'll re-open this. Could you please rebase so we can go ahead and merge this? |
Hi rebase done, and I pull the changes to my repo, what's the next??? |
@EcutDavid here's a good overview of what rebasing does (from link):
So once you have rebased, |
@shaurya947 Thank you very much, I did it :) |
@EcutDavid something seems a little off. There are a few commits in the PR that are already in master. Do you mind taking a look again? You got any suggestions @oliviertassinari ? |
Ok, I will take a look again In the midday :) |
Do you want me to rebase and open a PR with your commits? |
aaa5cc4
to
77708f6
Compare
Sorry, I made some mistake, |
OK it works now~ |
Cool stuff, thanks @EcutDavid! |
* Rename KeyboardIcon to CalendarIcon The icon components should be named after their content. * Rename `keyboardIcon` prop to `openPickerIcon` mui#1693 The prop should be named after the icon's functionality/usage. The new name matches the `hideOpenPickerButton` prop. The documentation on the prop already matches this wording. Tested by verifying that the two affected demo pages still work and show the customized icon. * Update lib/src/_shared/icons/CalendarIcon.tsx Co-Authored-By: Olivier Tassinari <[email protected]> Co-authored-by: Dmitriy Kovalenko <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
Fix theme display switch problem in doc.
issue page