"Maximum call stack size exceeded " fixes #4337 #4374

0zguner · 2016-05-28T14:15:49Z

Fixes " Maximum call stack size exceeded " #4337

I know this is a dirty fix. This might show people how to fix this issue. We also should update Readme about this issue. I'll send PR for Readme file.

Regards!

nathanmarks · 2016-06-01T00:15:57Z

@newoga Removing transform-replace-object-assign fixes this... any idea why? (it's causing a stackoverflow when transforming the svg-icons/index.js file)

0zguner · 2016-06-01T04:53:56Z

@nathanmarks @newoga It sounds like a babel issue to me 🤔

newoga · 2016-06-01T06:51:23Z

@nathanmarks No idea, when did this start happening? I haven't investigated yet but either way I was planning on removing this plugin for next release anyway. I'd probably vote to just do so before wasting too much time on it.

I had opened an issue about removing it some time ago: #3948

nathanmarks · 2016-06-01T12:37:06Z

@newoga Ok let's remove it.

nathanmarks · 2016-06-01T12:47:49Z

@newoga Ummm. So it looks like it was just pure coincidence. Now removing it isn't making a different 😄

0zguner · 2016-06-01T12:52:11Z

@nathanmarks can't you use this patch until we can find a decent fix about it ?

nathanmarks · 2016-06-01T12:53:42Z

@mzgnr We could, but I want to see what else can be done about it

nathanmarks · 2016-06-01T12:55:00Z

@newoga BTW it's only happening if I run the whole ./src folder through -- just babeling the svg-icons folder doesn't trigger the stack overflow. But when I run the whole folder through, it always fails on the svg-icons/index.js file.

nathanmarks · 2016-06-01T13:16:19Z

@oliviertassinari We could merge this, I don't see a better option right now after playing with it myself. I think this may need to be posted on the babel phabricator. It's not the file as when the babeling is broken up into smaller parts it doesn't happen.

newoga · 2016-06-01T16:06:14Z

@newoga Ummm. So it looks like it was just pure coincidence. Now removing it isn't making a different 😄

Oh man! That's frustrating, 😆. I spent sometime installing various older versions of babel and babel related dependencies and didn't get far enough to eliminate the issue either. Looking at their change log though, it looks like babel-traverse has been going through a lot of changes.

nathanmarks · 2016-06-01T17:56:04Z

@newoga I have a branch anyways with that facebook implementation copied for the change to address that issue. I'll ask on babel slack too see if anyone knows.

nathanmarks · 2016-06-01T22:16:24Z

https://phabricator.babeljs.io/T7402

oliviertassinari · 2016-06-02T17:12:31Z

I'm wondering, that looks like a hacky and temporary workaround. I would rather see this fixed at the Babel level. What do you think about closing this PR and keeping the issue open?

@nathanmarks Thanks for opening an issue on their tracker.

0zguner · 2016-06-02T18:09:35Z

I'm wondering... how you didn't face this issue ? I was not able to build package on v0.15-stable branch without this fix 🤔

newoga · 2016-06-02T18:13:50Z

I'm wondering... how you didn't face this issue ? I was not able to build package on v0.15-stable branch without this fix 🤔

@mzgnr My only guess is that a newer version of one of our dependencies changed the behavior and is causing this issue. I haven't been able to pinpoint when it happened though.

0zguner · 2016-06-02T18:39:20Z

@newoga Anyways. I was lucky enough to find the fix for this issue. This is the only fix i could find without changing project structure 😐

nathanmarks · 2016-06-02T18:43:16Z

We'll use this if babel hasn't fixed the issue before our next release. I agree with @oliviertassinari

0zguner · 2016-06-02T19:04:46Z

I also agree with @oliviertassinari . https://phabricator.babeljs.io/T7402#78943 here there is an explanation for this issue and his argument is true. stack size parameter adds more horse power to node.js & v8 engine. I think its not mostly babeljs issue its caused by this https://github.com/callemall/material-ui/blob/0.15-stable/src/svg-icons/index.js file. I guess its generated from icon index generator. That is the main problem rather than babel.

nathanmarks · 2016-06-02T19:50:20Z

@mzgnr He instructed me to post the issue on phabricator, so he must believe it is something babel should try and accomodate. No? Let's see what he ends up doing.

CumpsD · 2016-06-17T08:15:34Z

package.json

@@ -23,7 +23,7 @@
  "scripts": {
    "build": "npm run build:icon-index && npm run build:babel && npm run build:copy-files",
    "build:icon-index": "babel-node ./scripts/icon-index-generator.js",
-    "build:babel": "babel ./src --ignore *.spec.js --out-dir ./build",
+    "build:babel": "node --stack-size=10000 ./node_modules/.bin/babel ./src --ignore *.spec.js --out-dir ./build",


Are you sure this works on Windows? Shouldnt it be more like node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build?

Because .bin/babel is a linux file

@CumpsD I don't use Windows :( Can you test it if you are on Windows ? I can update PR with your suggestions :)

Partly, at least it now processes svg-icons (on Windows) but in the end it errors out with:

npm ERR! [email protected] build:babel: `node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build` npm ERR! Exit status 3221225725 npm ERR! npm ERR! Failed at the [email protected] build:babel script 'node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build'.

Not sure yet what it means :)

Ah, Google tells me

Exit code 3221225477 is C0000005 or ACCESS_VIOLATION

No clue why though

npm/npm#11024

I will continue in the issue :) Have another suggestion

CumpsD · 2016-06-17T09:35:31Z

Would this be an option?

    "build": "npm run build:icon-index && npm run build:babel && npm run build:babel-icons && npm run build:copy-files",
    "build:icon-index": "babel-node ./scripts/icon-index-generator.js",
    "build:babel": "babel ./src --ignore *.spec.js --ignore svg-icons --out-dir ./build",
    "build:babel-icons": "node --stack-size=100000 ./node_modules/babel-cli/bin/babel.js ./src/svg-icons --ignore *.spec.js --out-dir ./build/svg-icons",
    "build:copy-files": "babel-node ./scripts/copy-files.js",

Splitting it into a build without icons and a separate one for the icons.

This works on Windows :)

nathanmarks · 2016-06-17T16:00:02Z

@CumpsD would rather do the stack arg as the full build should work

CumpsD · 2016-06-17T17:00:33Z

But it does not :( crashes on index.js in svg-icons

fixes #4337

1897ad3

muibot added the PR: Needs Review label May 28, 2016

0zguner mentioned this pull request May 28, 2016

Maximum call stack size exceeded #4337

Closed

nathanmarks mentioned this pull request Jun 1, 2016

Package.json fix maximum call stack issue upon build. #4400

Closed

3 tasks

nathanmarks closed this Jun 1, 2016

nathanmarks reopened this Jun 1, 2016

nathanmarks closed this Jun 1, 2016

nathanmarks reopened this Jun 1, 2016

nathanmarks added the external dependency Blocked by external dependency, we can’t do anything about it label Jun 1, 2016

nathanmarks added on hold There is a blocker, we need to wait and removed PR: Needs Review labels Jun 2, 2016

CumpsD reviewed Jun 17, 2016
View reviewed changes

0zguner closed this Jun 28, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Maximum call stack size exceeded " fixes #4337 #4374

"Maximum call stack size exceeded " fixes #4337 #4374

0zguner commented May 28, 2016

nathanmarks commented Jun 1, 2016

0zguner commented Jun 1, 2016

newoga commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

0zguner commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

newoga commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

oliviertassinari commented Jun 2, 2016 •

edited

Loading

0zguner commented Jun 2, 2016

newoga commented Jun 2, 2016

0zguner commented Jun 2, 2016

nathanmarks commented Jun 2, 2016 •

edited

Loading

0zguner commented Jun 2, 2016

nathanmarks commented Jun 2, 2016

CumpsD Jun 17, 2016

0zguner Jun 17, 2016

CumpsD Jun 17, 2016

CumpsD Jun 17, 2016

CumpsD Jun 17, 2016

CumpsD Jun 17, 2016

CumpsD commented Jun 17, 2016

nathanmarks commented Jun 17, 2016

CumpsD commented Jun 17, 2016

"Maximum call stack size exceeded " fixes #4337 #4374

"Maximum call stack size exceeded " fixes #4337 #4374

Conversation

0zguner commented May 28, 2016

nathanmarks commented Jun 1, 2016

0zguner commented Jun 1, 2016

newoga commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

0zguner commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

newoga commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

nathanmarks commented Jun 1, 2016

oliviertassinari commented Jun 2, 2016 • edited Loading

0zguner commented Jun 2, 2016

newoga commented Jun 2, 2016

0zguner commented Jun 2, 2016

nathanmarks commented Jun 2, 2016 • edited Loading

0zguner commented Jun 2, 2016

nathanmarks commented Jun 2, 2016

CumpsD Jun 17, 2016

Choose a reason for hiding this comment

0zguner Jun 17, 2016

Choose a reason for hiding this comment

CumpsD Jun 17, 2016

Choose a reason for hiding this comment

CumpsD Jun 17, 2016

Choose a reason for hiding this comment

CumpsD Jun 17, 2016

Choose a reason for hiding this comment

CumpsD Jun 17, 2016

Choose a reason for hiding this comment

CumpsD commented Jun 17, 2016

nathanmarks commented Jun 17, 2016

CumpsD commented Jun 17, 2016

oliviertassinari commented Jun 2, 2016 •

edited

Loading

nathanmarks commented Jun 2, 2016 •

edited

Loading