Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Maximum call stack size exceeded " fixes #4337 #4374

Closed
wants to merge 1 commit into from
Closed

"Maximum call stack size exceeded " fixes #4337 #4374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"scripts": {
"build": "npm run build:icon-index && npm run build:babel && npm run build:copy-files",
"build:icon-index": "babel-node ./scripts/icon-index-generator.js",
"build:babel": "babel ./src --ignore *.spec.js --out-dir ./build",
"build:babel": "node --stack-size=10000 ./node_modules/.bin/babel ./src --ignore *.spec.js --out-dir ./build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this works on Windows? Shouldnt it be more like node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build?

Because .bin/babel is a linux file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CumpsD I don't use Windows :( Can you test it if you are on Windows ? I can update PR with your suggestions :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partly, at least it now processes svg-icons (on Windows) but in the end it errors out with:

npm ERR! [email protected] build:babel: `node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build`
npm ERR! Exit status 3221225725
npm ERR!
npm ERR! Failed at the [email protected] build:babel script 'node --stack-size=10000 ./node_modules/babel-cli/bin/babel.js ./src --ignore *.spec.js --out-dir ./build'.

Not sure yet what it means :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Google tells me

Exit code 3221225477 is C0000005 or ACCESS_VIOLATION

No clue why though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm/npm#11024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue in the issue :) Have another suggestion

"build:copy-files": "babel-node ./scripts/copy-files.js",
"clean:build": "rimraf build",
"lint": "eslint src docs/src test/integration && echo \"eslint: no lint errors\"",
Expand Down