Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove React.memo from GridCellCheckboxRenderer #6655

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[DataGrid] Remove React.memo from GridCellCheckboxRenderer #6655

merged 2 commits into from
Oct 31, 2022

Conversation

mattcorner
Copy link
Contributor

@mattcorner mattcorner commented Oct 28, 2022 •
edited by cherniavskii
Loading

Closes #6646

Tested with the demo provided on the ticket and confirmed that it resolves the issue.

@mattcorner mattcorner changed the title Remove React.memo [data grid] Remove React.memo from GridCellCheckboxRenderer Oct 28, 2022
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Oct 28, 2022
@cherniavskii cherniavskii added bug 🐛 Something doesn't work feature: Selection Related to the data grid Selection feature labels Oct 28, 2022
@cherniavskii
Copy link
Member

Thank you @mattcorner

@mui-bot
Copy link

mui-bot commented Oct 29, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6655--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 492.5 859.9 713.6 679.74 138.232
Sort 100k rows ms 634 1,040.8 789.9 856.64 147.826
Select 100k rows ms 164.8 278.1 226.2 225.58 37.094
Deselect 100k rows ms 162.9 229.7 188.1 197.22 24.087

Generated by 🚫 dangerJS against b7f8faa

@cherniavskii cherniavskii merged commit 152e43e into mui:next Oct 31, 2022
cherniavskii pushed a commit to cherniavskii/mui-x that referenced this pull request Oct 31, 2022
@mattcorner @oliviertassinari @cherniavskii
[data grid] Remove React.memo from GridCellCheckboxRenderer (mui#…
5c47453 
…6655)

Co-authored-by: Olivier Tassinari <[email protected]>
@cherniavskii cherniavskii changed the title [data grid] Remove React.memo from GridCellCheckboxRenderer [DataGrid] Remove React.memo from GridCellCheckboxRenderer Oct 31, 2022
@cherniavskii cherniavskii mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Remove React.memo from GridCellCheckboxRenderer
5 participants
@mattcorner @cherniavskii @mui-bot @zannager @oliviertassinari