Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove React.memo from GridCellCheckboxRenderer #6688

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[DataGrid] Remove React.memo from GridCellCheckboxRenderer #6688

merged 1 commit into from
Oct 31, 2022

Conversation

cherniavskii
Copy link
Member

Backport of #6655 to master branch

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature labels Oct 31, 2022
@cherniavskii cherniavskii mentioned this pull request Oct 31, 2022
Merged
1 task
@mui-bot
Copy link

mui-bot commented Oct 31, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 477.7 812.4 625.3 616.6 121.797
Sort 100k rows ms 547.4 1,009 547.4 896.8 175.939
Select 100k rows ms 211.9 303.5 220.6 244.1 36.388
Deselect 100k rows ms 131.2 303.4 193.7 198.84 63.119

Generated by 🚫 dangerJS against 5c47453

@cherniavskii cherniavskii merged commit 7e6bb31 into mui:master Oct 31, 2022
@cherniavskii cherniavskii deleted the remove-memo-checkbox branch October 31, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherniavskii @mui-bot @mattcorner