-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Add Ukrainian (uk-UA) locale on the date picker #6661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To le make it work, it need to be export from locale/index.ts
.
And you can add a line to the table of supported locales to say Ukrainian is supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, every think sounds nice :)
The CI seems flaky, I will add an empty commit, to see if let it run
These are the results for the performance tests:
|
@alexfauquette |
You can run |
@alexfauquette Added changes can you please kick CircleCI Pipeline one more time |
#6704) Co-authored-by: oleksandr.korol <[email protected]>
time === null ? 'Час не вибраний' : `Вибрано час ${adapter.format(time, 'fullTime')}` | ||
}`, | ||
hoursClockNumberText: (hours) => `${hours} годин`, | ||
minutesClockNumberText: (minutes) => `${minutes} хвилин`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a potential improvement, we can use different plural forms depending on the number like we do in the data grid:
mui-x/packages/grid/x-data-grid/src/locales/ukUA.ts
Lines 46 to 51 in 099729f
toolbarFiltersTooltipActive: (count) => | |
getPluralForm(count, { | |
one: 'активний фільтр', | |
few: 'активні фільтри', | |
many: 'активних фільтрів', | |
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I saw your profile picture, then I thought you did a language review but it was your self-assignment 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexfauquette no worries 🙂
@Dufran Feel free to open a follow-up PR if you want
No description provided.