Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Ukrainian (uk-UA) locale on the date picker #6661

Merged
merged 10 commits into from
Nov 1, 2022

Conversation

Dufran
Copy link

@Dufran Dufran commented Oct 28, 2022

No description provided.

@cherniavskii cherniavskii self-assigned this Oct 28, 2022
@cherniavskii cherniavskii added component: pickers This is the name of the generic UI component, not the React module! i18n internationalization labels Oct 28, 2022
@oliviertassinari oliviertassinari added l10n localization and removed i18n internationalization labels Oct 29, 2022
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To le make it work, it need to be export from locale/index.ts.

And you can add a line to the table of supported locales to say Ukrainian is supported

packages/x-date-pickers/src/locales/ukUA.ts Outdated Show resolved Hide resolved
@Dufran Dufran requested review from alexfauquette and removed request for flaviendelangle and LukasTy November 1, 2022 06:07
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, every think sounds nice :)

The CI seems flaky, I will add an empty commit, to see if let it run

@mui-bot
Copy link

mui-bot commented Nov 1, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6661--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 849.6 1,379.4 849.6 1,012.48 208.774
Sort 100k rows ms 719.3 1,395.7 1,395.7 1,117.28 288.705
Select 100k rows ms 257.8 454.3 311.2 331.14 72.762
Deselect 100k rows ms 151.9 301.3 193.5 223.8 58.67

Generated by 🚫 dangerJS against 43792b6

@Dufran
Copy link
Author

Dufran commented Nov 1, 2022

@alexfauquette
Thanks for help through the process. It still seems to be some errors in ci/circleci: test_static job, did I miss something?

@alexfauquette
Copy link
Member

You can run yarn docs:api and commit changes. It will add ukUA to the list of exported variables

@Dufran
Copy link
Author

Dufran commented Nov 1, 2022

@alexfauquette Added changes can you please kick CircleCI Pipeline one more time

@alexfauquette alexfauquette merged commit 099729f into mui:next Nov 1, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Nov 1, 2022
alexfauquette added a commit that referenced this pull request Nov 1, 2022
time === null ? 'Час не вибраний' : `Вибрано час ${adapter.format(time, 'fullTime')}`
}`,
hoursClockNumberText: (hours) => `${hours} годин`,
minutesClockNumberText: (minutes) => `${minutes} хвилин`,
Copy link
Member

@cherniavskii cherniavskii Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a potential improvement, we can use different plural forms depending on the number like we do in the data grid:

toolbarFiltersTooltipActive: (count) =>
getPluralForm(count, {
one: 'активний фільтр',
few: 'активні фільтри',
many: 'активних фільтрів',
}),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I saw your profile picture, then I thought you did a language review but it was your self-assignment 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfauquette no worries 🙂
@Dufran Feel free to open a follow-up PR if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants