Fix #59, getToken succeeds when token not supplied

Includes fix and test case
mulesoft-labs · Mar 22, 2018 · 3094a85 · 3094a85
1 parent 30fe581
commit 3094a85
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/client-oauth2.js b/src/client-oauth2.js
@@ -469,7 +469,7 @@ TokenFlow.prototype.getToken = function (uri, opts) {
 
   // If no query string or fragment exists, we won't be able to parse
   // any useful information from the uri.
-  if (!url.hash && !url.query) {
+  if (!url.hash && !url.search) {
     return Promise.reject(new TypeError('Unable to process uri: ' + uri))
   }
 

diff --git a/test/token.js b/test/token.js
@@ -47,5 +47,14 @@ describe('token', function () {
           })
       })
     })
+
+    it('should fail if token not present', function (done) {
+      githubAuth.token.getToken(config.redirectUri)
+        .then(function (ignore) {
+          done(new Error('Promise should fail'))
+        }, function (reason) {
+          done() // Promise is rejected - pass
+        })
+    })
   })
 })