Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

getToken succeeds when token is not supplied #59

Closed
lod opened this issue Nov 9, 2017 · 1 comment
Closed

getToken succeeds when token is not supplied #59

lod opened this issue Nov 9, 2017 · 1 comment

Comments

@lod
Copy link
Contributor

lod commented Nov 9, 2017

calling client.token.getToken('http://localhost/') resolves with undefined values such as access_token

The expectation is that the promise should reject.

The bug is partially caused by this line
if (!url.hash && !url.query) {

where url = Url.parse(uri, true)
url.query = {}
{} == true

@jstoiko
Copy link
Contributor

jstoiko commented Mar 20, 2018

@lod: feel free to submit a PR

jstoiko added a commit that referenced this issue Mar 31, 2018
Fix #59, getToken succeeds when token not supplied
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants