Fix #21900: Note highlighting on the piano keyboard ignores ottava. #22443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #21900
Bug: The pianokeyboard view was not taking into account the ottavas, so if you put an ottava on the score you would hear the pitched-up note, but the note you would see on the keyboard view would not be pitched-up by an octave as well.
Solution: In the class Note there are multiple computations for pitch, for different purposes. I've used the playback pitch (ppitch) instead of the effective pitch (epitch) on the pianokeyboardcontroller.cpp, because the playback audio was using the pitch I wanted shown on the keyboard.
Tested on Windows.