Added buttons for PianoKeyboard to switch between Notated Pitch (effective pitch) and Playback Pitch.

[NathanPrazeres]

Resolves: #15594

Title describes well enough. We just added buttons in the PianoKeyboardPanelContextMenuModel class that communicate with the PianoKeyboardController class to change a boolean variable. The aim is to address a limitation in the current implementation of MuseScore's keyboard view, which struggles with differently-tuned instruments. When users click on a key, the corresponding note used to be placed on the score as notated pitch, while the equivalent standard pitch was highlighted on the keyboard UI, leading to potential confusion.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually

[cbjeukendrup]

That's looking much better already! I have a few more cleanup suggestions, but nothing fundamental!

[cbjeukendrup]

Perhaps, instead of "checkable", we should use "selectable". That is not a property of UiAction but of MenuItem.

So: item->setSelectable(true) to mark the item as selectable, and then bool selected = …; item->setSelected(selected) to set the state.

[shoogle]

Here I have selected C4 in the score and it is correctly highlighted as Bb3 in the piano keyboard.

However, if I press Bb3 in the piano keyboard it gives me a Bb3 (actually A#3) in the score instead of C4.

I would expect the "Use playback pitch" option to work for entering notes as well as for highlighting exisiting ones.

[051056]

Hello,
Please, let me know when this fonction (Added buttons for PianoKeyboard to switch between Notated Pitch)will be avalaible.
Thanks

[rpatters1]

It is unclear to me what remains to do with this pull request? Is it just the final code review item?

[rpatters1]

@cbjeukendrup I am trying to revive this PR. I have rebased my branch of it (with effort) on the current master branch.

It all seems to be working so far as it went, except for the problem noted in the comment above that when "Use playback pitch" is selected, it still enters the notated pitch into the score. It looks like NotationMidiInput::addNoteToScore may need to be modifed as well. I could use some direction on the most judicious change.

EDIT: I figured it out.

[rpatters1]

This pull request is now completed as #24784

[cbjeukendrup]

@NathanPrazeres Thanks for your work; although it has not been merged directly, it has been included in a new PR that expands on it, and will be finished via that PR!

[NathanPrazeres]

Sorry for leaving this unfinished. I really haven't had time as of late. I'll glad it will be useful anyways. Thanks :)

[shoogle]

@NathanPrazeres, no worries! Thanks for your contribution!