Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch PianoKeyboard between Notated Pitch (effective pitch) and Playback Pitch (completed). #24784

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Switch PianoKeyboard between Notated Pitch (effective pitch) and Playback Pitch (completed). #24784

merged 14 commits into from
Oct 4, 2024
+140 −18

Commits on Oct 2, 2024

  1. Changes to revive and complete PR musescore#22991.

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9132db0 View commit details
    Browse the repository at this point in the history

  2. no message

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d5ca74a View commit details
    Browse the repository at this point in the history

  3. changes for all midi inputs

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9711ea2 View commit details
    Browse the repository at this point in the history

  4. Move property getter and setter for pianoKeyboardUseNotatedPitch to I… 

    …EngravingConfiguration to make it accessible in Score class.
    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fc698e7 View commit details
    Browse the repository at this point in the history

  5. uncrustification

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c244f27 View commit details
    Browse the repository at this point in the history

  6. remove unneeded stub functions

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    867ca44 View commit details
    Browse the repository at this point in the history

  7. reverted to using INotationConfiguration with a boolean passed into S… 

    …core, plus other codereview fixes.
    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    03e217a View commit details
    Browse the repository at this point in the history

  8. move menu to playback bar and use terse menu text

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    47d2f72 View commit details
    Browse the repository at this point in the history

  9. make function name consistent with UI

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8c8c62e View commit details
    Browse the repository at this point in the history

  10. clean up cruft

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    144de39 View commit details
    Browse the repository at this point in the history

  11. one more name change (they say naming is the hardest thing in program… 

    …ming)
    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ab64440 View commit details
    Browse the repository at this point in the history

  12. stub module did not get name changes (because it's not in any project… 

    …, arghh)
    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d44b99e View commit details
    Browse the repository at this point in the history

  13. code review items

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1dc1d35 View commit details
    Browse the repository at this point in the history

  14. naming is the hardest thing

    @rpatters1
    rpatters1 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6a0159d View commit details
    Browse the repository at this point in the history