refactor(iroh-gossip): make use of Endpoint::direct_addresses in iroh_gossip::net

[Frando]

Description

iroh_gossip::net::Gossip had a method to update the direct addresses of the iroh_net::Endpoint. IIRC that dates back when the Endpoint only exposed a single, non-cloneable stream of endpoint events, which was handled in the iroh Node and thus had to be forwarded to consumers like Gossip. This was long ago and by now the Endpoint provides a capable API for this. Therefore there is no need to expose this as a method (because Gossip always contains an Endpoint).

Breaking Changes

Gossip::update_direct_addresses is removed. Updating the direct addresses is now handled by Gossip automatically.

Notes & open questions

To react to all updates to the endpoint's NodeAddr, I am watching both Endpoint::direct_addresses and Endpoint::watch_home_relay. A simpler API for this usecase would be Endpoint::watch_node_addr.

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2731/docs/iroh/

Last updated: 2024-09-16T12:28:32Z

[dignifiedquire]

nice