feat(iroh-net): add Endpoint::watch_node_addr #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2732/docs/iroh/ Last updated: 2024-09-16T14:21:28Z |
Frando
force-pushed
the
feat-net-watch-node-addr
branch
from
928d0a5
to
03e65c4
Compare
|
Assigning to myself as @Frando is now OOO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
Endpoint::watch_node_addrwhich returns a stream that yieldsNodeAddr.We have
Endpoint::direct_addressesandEndpoint::watch_home_relay. In #2731 what I needed, and what I suspect apps will oftenly need, is the combination of both: Give me a stream that yields the endpoint's NodeAddr whenever it changes, either due to a change in our home relay, or due to a change in our discovered addresses.Breaking Changes
Notes & open questions
Change checklist