Generate .d.ts files for node gRPC services #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esilkensen
force-pushed
the
feature/grpc-service-ts-support
branch
from
474d38a
to
caf34ef
Compare
esilkensen
commented
Sep 3, 2019
| @@ -39,7 +39,7 @@ testGeneration() { | |||
| if [[ "$extra_args" == *"--with-typescript"* ]]; then | |||
| # Test that we have generated the .d.ts files. | |||
| ts_file_count=$(find $expected_output_dir -type f -name "*.d.ts" | wc -l) | |||
| if [ $ts_file_count -eq 0 ]; then | |||
| if [ $ts_file_count -ne 2 ]; then | |||
There was a problem hiding this comment.
outputs are
- test_pb.d.ts
- test_grpc_pb.d.ts
|
Hey, just getting back from vacation. Is this good to go? |
|
Sounds good! Yes should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #125 added the
--with-typescriptoption to generate .d.ts declaration files for node using the ts-protoc-gen plugin, but it didn't generate .d.ts files for gRPC services.This PR adds support for that, fixing issue #138, by bumping the ts-protoc-gen version from 0.10.0 to 0.11.0 (which includes improbable-eng/ts-protoc-gen#193, introducing the
service=grpc-nodeoption to generate those .d.ts files).