Remove VIGRA support #122
Merged
Remove VIGRA support #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
As we manage the bindings through Cython and the C++ code is easily usable, there is not much need in maintaining VIGRA bindings. Especially as this library is mainly used through Python. So go ahead stop testing VIGRA on CI in preparation of removing the VIGRA bindings.
As we are no longer supporting or using the VIGRA C++ bindings, go ahead and drop those from the headers.
As there is no need to separate out a non-VIGRA/base portion of the C++ rank filter algorithm into another header, go ahead and rename it to `rank_filter.hxx` dropping `rank_filter_base.hxx` in the process.
As we are no longer shipping the VIGRA bindings, there is no need to have VIGRA C++ tests. So go ahead and drop them.
No need to signify these C++ tests as base tests as they are the only C++ tests.
No need to search for VIGRA as we are no longer using it.
As we have stripped `_base` from the C++ tests, cleanup the CMake build accordingly.
Comparison here was incorrect in that it referenced VIGRA when it shouldn't. So drop the VIGRA reference.
As the `_base` suffix has been dropped, update the Cython header accordingly.
Drop `_base` suffix from C++ header as it is has been renamed.
Drop use of base in all names as this is no longer a relevant designator and some files have already been renamed.
Drop `_base` from C++ executable as it is no longer a relevant designator.
jakirkham
force-pushed
the
rm_vigra_support
branch
from
6e162e2
to
190d547
Compare
As the header file has been renamed, the guard should also be updated.
No need to reference a subset of C++ tests. These are all of the C++ tests now.
|
Going ahead and merging as the last two commits should have negligible effect on the already passing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for VIGRA C++ bindings as these are no longer used or maintained.