Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VIGRA support #122

Merged
merged 17 commits into from
Oct 14, 2018
Merged

Remove VIGRA support #122

merged 17 commits into from
Oct 14, 2018

Commits on Oct 14, 2018

  1. Drop VIGRA from CI tests 

    As we manage the bindings through Cython and the C++ code is easily
usable, there is not much need in maintaining VIGRA bindings. Especially
as this library is mainly used through Python. So go ahead stop testing
VIGRA on CI in preparation of removing the VIGRA bindings.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    47bbde7 View commit details
    Browse the repository at this point in the history

  2. Drop VIGRA C++ bindings 

    As we are no longer supporting or using the VIGRA C++ bindings, go ahead
and drop those from the headers.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    ff68bca View commit details
    Browse the repository at this point in the history

  3. Consolidate headers 

    As there is no need to separate out a non-VIGRA/base portion of the C++
rank filter algorithm into another header, go ahead and rename it to
`rank_filter.hxx` dropping `rank_filter_base.hxx` in the process.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    b4ac1a0 View commit details
    Browse the repository at this point in the history

  4. Drop VIGRA tests 

    As we are no longer shipping the VIGRA bindings, there is no need to
have VIGRA C++ tests. So go ahead and drop them.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    2ef7e19 View commit details
    Browse the repository at this point in the history

  5. Rename the rank filter C++ tests 

    No need to signify these C++ tests as base tests as they are the only
C++ tests.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    4d9203c View commit details
    Browse the repository at this point in the history

  6. Drop CMake VIGRA detection module 

    No need to search for VIGRA as we are no longer using it.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    63100ca View commit details
    Browse the repository at this point in the history

  7. Drop VIGRA portions from CMake build

    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    eaecd92 View commit details
    Browse the repository at this point in the history

  8. Update CMake C++ test phase 

    As we have stripped `_base` from the C++ tests, cleanup the CMake build
accordingly.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    885e2ab View commit details
    Browse the repository at this point in the history

  9. Drop VIGRA from conda-build recipe

    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    400e12a View commit details
    Browse the repository at this point in the history

  10. Drop references to VIGRA build from README

    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    f892515 View commit details
    Browse the repository at this point in the history

  11. Fix-up Python CMake detection 

    Comparison here was incorrect in that it referenced VIGRA when it
shouldn't. So drop the VIGRA reference.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    23426cb View commit details
    Browse the repository at this point in the history

  12. Fix C++ header name in Cython header 

    As the `_base` suffix has been dropped, update the Cython header
accordingly.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    b5e391e View commit details
    Browse the repository at this point in the history

  13. Fix up MANIFEST.in 

    Drop `_base` suffix from C++ header as it is has been renamed.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    c32a07e View commit details
    Browse the repository at this point in the history

  14. Fix up naming in C++ tests 

    Drop use of base in all names as this is no longer a relevant designator
and some files have already been renamed.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    5bff16a View commit details
    Browse the repository at this point in the history

  15. Update C++ executables to ignore with git 

    Drop `_base` from C++ executable as it is no longer a relevant
designator.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    190d547 View commit details
    Browse the repository at this point in the history

  16. Rename __RANK_FILTER_BASE__ to __RANK_FILTER__ 

    As the header file has been renamed, the guard should also be updated.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    8c41153 View commit details
    Browse the repository at this point in the history

  17. Update CMake comment about C++ tests 

    No need to reference a subset of C++ tests. These are all of the C++
tests now.
    @jakirkham
    jakirkham committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    d70ceef View commit details
    Browse the repository at this point in the history