Remove lambda wrappers #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we intend to use the filter as an in-place filter, go ahead and provide only one array argument in the `lambda` function and reuse it for input and output. This should help simplify the surrounding code a bit as well.
There is no need to store the selection from `out_swap` now that it is only being passed into one argument in the `lambda` function. So go ahead and remove it and simplify the surrounding code.
Change `lineRankOrderFilter1D_floating` to run in-place as that is our typical usage of this function. Also update the surrounding code accordingly. Cuts down on setup time a bit.
Instead of using `lambda` wrappers`, simply call the fused type function directly with the intended specialization. Should cutdown the overhead of dispatch and make it easier for the compiler to inline it. This remains pretty compact thanks to the conversion of the function to an in-place computation and some previous refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some cleanup to remove the
lambdawrappers for the lower level C++ wrapper function. Also converts the C++ wrapper function to an in-place computation. Helps cleanup the surrounding code a bit and makes the removal oflambdawrappers cleaner.