Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lambda wrappers #139

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Remove lambda wrappers #139

merged 4 commits into from
Oct 16, 2018

Commits on Oct 15, 2018

  1. Make lambda an in-place computation 

    As we intend to use the filter as an in-place filter, go ahead and
provide only one array argument in the `lambda` function and reuse it
for input and output. This should help simplify the surrounding code a
bit as well.
    @jakirkham
    jakirkham committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    6a81454 View commit details
    Browse the repository at this point in the history

  2. Drop out_strip 

    There is no need to store the selection from `out_swap` now that it is
only being passed into one argument in the `lambda` function. So go
ahead and remove it and simplify the surrounding code.
    @jakirkham
    jakirkham committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    8aba0d0 View commit details
    Browse the repository at this point in the history

  3. Make lineRankOrderFilter1D_floating run in-place 

    Change `lineRankOrderFilter1D_floating` to run in-place as that is our
typical usage of this function. Also update the surrounding code
accordingly. Cuts down on setup time a bit.
    @jakirkham
    jakirkham committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    13fb371 View commit details
    Browse the repository at this point in the history

  4. Eliminate lambda wrappers 

    Instead of using `lambda` wrappers`, simply call the fused type function
directly with the intended specialization. Should cutdown the overhead
of dispatch and make it easier for the compiler to inline it. This
remains pretty compact thanks to the conversion of the function to an
in-place computation and some previous refactoring.
    @jakirkham
    jakirkham committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    70a1b7d View commit details
    Browse the repository at this point in the history