Fix linkage to vigranumpy on Mac #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the linkage to vigranumpy gets pointed at the wrong path. To fix this, we go ahead and run `install_name_tool` on Mac to change the path back to the absolute path. As `conda-build` can go back through and fix this for us, we go ahead and let it do this to get back to a correct, relative RPATH. This is a different approach to a similar issue we experienced on Linux some time ago.
jakirkham
force-pushed
the
mac_fix_vigranumpy
branch
from
5809ca1
to
8ea8844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the linkage to vigranumpy gets pointed at the wrong path. To fix this, we go ahead and run
install_name_toolon Mac to change the path back to the absolute path. Asconda-buildcan go back through and fix this for us, we go ahead and let it do this to get back to a correct, relative RPATH. This is a different approach to a similar issue we experienced on Linux some time ago. ( #21 )