Telemetry Table menu actions not available in Preview mode

[ozyx]

Summary

Actions like "Export Marked Rows" on the TelemetryTable 3dot menu aren't available in Preview mode, but it feels like they should be?

@charlesh88 Is this a defect?

Expected vs Current Behavior

TelemetryTable specific menu actions (such as "Export Marked Rows") should be available in the 3dot menu when I'm:

1. ✅ Viewing a TelemetryTable object

2. ✅ Viewing a TelemetryTable object in "Large View" mode (clicking on "Large View" button from the object embedded in a layout)

Screen.Recording.2023-10-20.at.1.40.48.PM.mov

3. ❌ Viewing a TelemetryTable object in Preview mode (clicking on a TelemetryTable object or Telemetry w/ Table view in the tree while editing another object).

Screen.Recording.2023-10-20.at.1.36.50.PM.mov

Steps to Reproduce

1. Create a Sine Wave Generator
2. Create a Display Layout and leave it in edit mode
3. Click on the Sine Wave Generator in the tree to preview it
4. Click the 3dot menu and notice that actions like "Export Marked Rows" are not available

Environment

• Open MCT Version: 3.2.0-next
• Deployment Type: any
• OS: any
• Browser: any

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[charlesh88]

This is most definitely a bug. The Telemetry Table view should have the same capabilities regardless of how it was invoked.

Additional Notes About Reproduction

1. Create or go to a view that uses the telemetry table view, like a numeric data source.
2. In the main view, note the controls available and the contents of the More Options menu (3 dot menu) in the upper right.
3. Nav away from the object, then find it in the tree. Context-click it there and select "View" from the context menu.
4. Observe that available controls, and the contents of the More Options menu are different and very limited.

Full, desired table capabilities from the main view:

Invoking "View" from the tree:

The 2nd, limited table view in the Large View overlay:

The correct table view is available from a Display Layout's "Large View":

[scottbell]

To test:

1. Create a SWG
2. Create a Telemetry Table, and add the SWG
3. While viewing the Telemetry Table, click the More Options menu (3 dot menu) in the upper right.
4. Ensure you can see actions like "Export Marked Rows".
5. Create a DisplayLayout, and put it in edit mode
6. Click the Telemetry Table in the tree to a get a Preview
7. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table preview
8. Ensure you can see actions like "Export Marked Rows"
9. Close the Preview
10. Drag the Telemetry Table to the Display Layout and save
11. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table in the Display Layout
12. Ensure you can see actions like "Export Marked Rows"
13. Click the "View Large" action
14. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table in the preview
15. Ensure you can see actions like "Export Marked Rows"

[jvigliotta]

Verified Fixed with a caveat: 3/20/24
When you select "Large View" from the 3-dot menu, the table is automatically "paused" and no rows are selected, yet you the Export Marked Rows action is available.

Normal behavior, no marked rows, so no option to export them.

When in View Large, table is "paused" and export marked rows is available, believe this is a bug. Also, clicking play doesn't "unpause" it.

[scottbell]

Note this issue appears more widespread. E.g., the Timer object has the same issues:

Screen.Recording.2024-03-21.at.10.22.20.AM.mov

Note the controls all function, but they're not updating their display appropriately to state changes. The original action bar (i.e., the one in the Display Layout) is receiving the state changes, but the action bar in the PreviewContainer is not.

From investigation, the issue appears moving from v2.2.5 to v3.0.0, so I'm betting it's a Vue3 issue and the way it mounts components vs. the Vue2 mounts components. When using an existing view, the PreviewContainer is moving the component to an overlay, and I'm guessing the view is still pointing to the old action bar instead of the new one.

[scottbell]

The issue is getActionsCollection isn't returning the cached ActionsCollection, and is instead creating a new one for the Preview. This new ActionsCollection doesn't receive the updates from the View object, and so doesn't respond appropriately to changes.

[scottbell]

To test:

1. Create a SWG
2. Create a Telemetry Table, and add the SWG
3. While viewing the Telemetry Table, click the More Options menu (3 dot menu) in the upper right.
4. Ensure you can see actions like "Export Marked Rows".
5. Create a DisplayLayout, and put it in edit mode
6. Click the Telemetry Table in the tree to a get a Preview
7. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table preview
8. Verify you can see "Export Marked Rows", be sure it's disabled
9. Verify you can see "Pause"
10. Close the Preview
11. Drag the Telemetry Table to the Display Layout and save
12. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table in the Display Layout
13. Ensure you can see actions like "Export Marked Rows"
14. Click the "View Large" action
15. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table in the preview
16. Verify you can see "Export Marked Rows", be sure it's disabled
17. Verify you can see "Pause"
18. Click the "Pause"
19. The table should now be paused, with the play button visible
20. Click the More Options menu (3 dot menu) in the upper right of the Telemetry Table in the preview
21. Verify you can see "Play"

Do the same for Timer object in a Display Layout. The Actions should be similarly reactive.