Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure object specific actions load in previews #7504

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Feb 15, 2024

Closes #7488
Closes #7158

Describe your changes:

Wait until the next tick to load the actions, so the elements have had time to render.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Feb 15, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd560bc) 55.34% compared to head (170c474) 55.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7504      +/-   ##
==========================================
+ Coverage   55.34%   55.37%   +0.03%     
==========================================
  Files         671      671              
  Lines       27010    27010              
  Branches     2631     2631              
==========================================
+ Hits        14948    14958      +10     
+ Misses      11339    11329      -10     
  Partials      723      723              
Flag Coverage Δ *Carryforward flag
e2e-full 41.13% <ø> (ø) Carriedforward from cd560bc
e2e-stable 59.19% <ø> (+0.02%) ⬆️
unit 48.45% <100.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/ui/preview/PreviewContainer.vue 28.39% <100.00%> (-2.47%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd560bc...170c474. Read the comment docs.

@scottbell scottbell changed the title Have actions Ensure object specific actions load in previews Feb 15, 2024
@scottbell scottbell requested a review from ozyx February 15, 2024 13:13
@scottbell scottbell marked this pull request as ready for review February 15, 2024 13:17
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to fix both issues

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
@ozyx ozyx enabled auto-merge (squash) February 15, 2024 17:55
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
@ozyx ozyx merged commit 4fbccd4 into master Feb 15, 2024
24 checks passed
@ozyx ozyx deleted the 7488-view-large-mutating-its-own-dependencies branch February 15, 2024 18:00
@scottbell scottbell modified the milestones: Target:4.0.0, Target:4.0.1 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View Large" mutating its own dependencies Telemetry Table menu actions not available in Preview mode
2 participants