Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fault Management] Cannot acknowledge or shelve faults with bulk actions #7215

Closed
4 of 7 tasks
unlikelyzero opened this issue Nov 8, 2023 · 3 comments · Fixed by #7559
Closed
4 of 7 tasks

[Fault Management] Cannot acknowledge or shelve faults with bulk actions #7215

unlikelyzero opened this issue Nov 8, 2023 · 3 comments · Fixed by #7559
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone

Comments

@unlikelyzero
Copy link
Collaborator

Summary

Users are currently unable to acknowledge or shelve faults in the fault management view with the bulk actions.

Expected vs Current Behavior

When selecting one or many faults in the fault management screen, the user should be able to shelve or acknowledge a fault. Today they do not

Steps to Reproduce

  1. Create an alarm or two
  2. Navigate to the Fault Management View
  3. Select the checkbox for all alarms
  4. Note: the shelve and acknowledge buttons do not highlight

Environment

  • Open MCT Version: 3.2.0
  • Deployment Type: openmct-yamcs and viper

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@unlikelyzero
Copy link
Collaborator Author

Critical

@ozyx ozyx self-assigned this Mar 6, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 6, 2024
@ozyx ozyx closed this as completed in #7559 Mar 6, 2024
ozyx added a commit that referenced this issue Mar 6, 2024
…ith single and bulk actions (#7559)

* refactor: merge FaultManagementListView into FaultManagementView

* refactor: make `selectedFaults` a computed property

* refactor: use named exports

* fix: reset fault map AFTER selectedFaults have been acknowledged

* a11y: add aria labels for fault management toolbar buttons

* refactor: use named import/exports

* a11y: add label

* a11y: add aria label for checkboxes

* fix: acknowledging or shelving single fault from context menu should only apply to selected fault

* refactor: use change event instead of input event for checkbox

* test: fix e2e tests, remove expect.softs

* test: stabilize fault management e2e tests
@ozyx
Copy link
Member

ozyx commented Mar 12, 2024

Testing Instructions

In our Test Environment:

  • Navigate to Fault Management static object in the tree
  • Create a fault
  • Confirm it appears in the view

Acknowledge a single fault

  • Check a single fault
  • Verify that the "Acknowledge" and "Shelve" buttons become enabled
  • Click "Acknowledge" and leave a comment. Confirm the dialog.
  • Verify the single Fault has a checkmark on it and is slightly grayed
  • Click the dropdown in the top right to filter only to "Acknowledged" and verify the single fault appears.
  • Set the filter back to default

Acknowledge multiple faults

  • Check multiple un-acked faults
  • Click Acknowledge
  • Repeat the steps above and verify that both are acknowledged

Acknowledge a single fault with the context menu

  • Check multiple faults
  • Click on the context menu of one unacked fault and select "Acknowledge"
  • Verify that the dialog states it is acknowledging only the fault for which the context menu was selected
  • Confirm the dialog
  • Verify that the single fault was acknowledged and all previously checked faults are unchecked

Shelving faults

  • Repeat the steps above but for Shelving faults, verifying that faults disappear from the view once shelved.
  • Change the filter to "Shelved" and verify they appear again in the view.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 3/14/24
No issues observed all working as expected.

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
3 participants