Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7215)[Fault Management]: Fix shelving and acknowledging faults with single and bulk actions #7559

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Mar 6, 2024

Closes #7215

Describe your changes:

  • Makes shelvedFaults a computed property to fix Vue reactivity
  • Fixes issue where acknowledging a single fault via the context menu while others were checked would acknowledge only the checked faults.
  • Merges FaultManagementListView into FaultManagementView to simplify
  • Adds some a11y
  • Promote fault management e2e tests to stable and remove expect.softs

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:bug label Mar 6, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 3.94737% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (df96972) to head (7399fc1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7559      +/-   ##
==========================================
- Coverage   55.58%   55.30%   -0.28%     
==========================================
  Files         673      672       -1     
  Lines       26994    27003       +9     
  Branches     2623     2624       +1     
==========================================
- Hits        15004    14934      -70     
- Misses      11271    11348      +77     
- Partials      719      721       +2     
Flag Coverage Δ
e2e-full 23.30% <0.00%> (-18.61%) ⬇️
e2e-stable 59.57% <100.00%> (+0.12%) ⬆️
unit 48.48% <1.31%> (-0.04%) ⬇️
Files Coverage Δ
example/faultManagement/exampleFaultSource.js 100.00% <100.00%> (+30.76%) ⬆️
example/faultManagement/utils.js 77.27% <ø> (+13.63%) ⬆️
...gins/faultManagement/FaultManagementListHeader.vue 0.00% <ø> (ø)
...plugins/faultManagement/FaultManagementToolbar.vue 0.00% <0.00%> (ø)
...lugins/faultManagement/FaultManagementListItem.vue 4.54% <0.00%> (-0.46%) ⬇️
...rc/plugins/faultManagement/FaultManagementView.vue 1.20% <0.00%> (+1.20%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df96972...7399fc1. Read the comment docs.

.getByLabel('Select fault')
.nth(rowNumber - 1)
.check({
// Need force here because checkbox state is changed by an event emitted by the checkbox
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gross

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep but i'd rather this than have to restructure all of fault management

await utils.clearSearch(page);
faultResultCount = await utils.getFaultResultCount(page);
expect.soft(faultResultCount).toEqual(5);
await clearSearch(page);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what in tarnation


// search triggerTime
await utils.enterSearchTerm(page, faultFiveTriggerTime);
await enterSearchTerm(page, faultFiveTriggerTime);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhh

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and added #7561 to our backlog

@ozyx ozyx merged commit ab49f3f into master Mar 6, 2024
33 of 40 checks passed
@ozyx ozyx deleted the mct7215 branch March 6, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fault Management] Cannot acknowledge or shelve faults with bulk actions
2 participants