Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flex Layout] Remove Frame button doesn't work anymore #7234

Closed
2 of 7 tasks
rukmini-bose opened this issue Nov 13, 2023 · 3 comments · Fixed by #7240 or #7244
Closed
2 of 7 tasks

[Flex Layout] Remove Frame button doesn't work anymore #7234

rukmini-bose opened this issue Nov 13, 2023 · 3 comments · Fixed by #7240 or #7244
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Nov 13, 2023 •
edited by ozyx
Loading

Summary

The "Remove Frame" button in Flexible Layouts does not work anymore. This can get slightly problematic if a user adds a frame to a layout, then decides they don't want it anymore. There's no way to remove the frame at this point. There's a workaround to removing an object in the layout (using the Elements Pool).

Expected vs Current Behavior

When a user clicks on a frame or object in a Flexible Container and clicks the "Remove Frame" button, the selected object/frame should be removed. This however, does not happen.

Steps to Reproduce

  1. Create/Navigate to a Flexible Layout
  2. Add an object to the layout.
  3. Try to remove the object from the layout using the "Remove Frame" button in the toolbar. Observe that after pressing "ok" on the confirmation dialog, the object does not get removed.
  4. Press the "Add Container" button. Repeat step 3 and observe the same thing happening.

Environment

  • Open MCT Version: 3.2.0-next
  • Deployment Type: Testathon
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx changed the title [Flex Layout] Remove Frame button work anymore [Flex Layout] Remove Frame button doesn't work anymore Nov 14, 2023
@ozyx ozyx self-assigned this Nov 14, 2023
ozyx added a commit that referenced this issue Nov 16, 2023
@ozyx
fix(#7234): fix event name for flexible layout toolbar action
5405bad
@ozyx ozyx mentioned this issue Nov 16, 2023
Merged
15 tasks
unlikelyzero pushed a commit that referenced this issue Nov 16, 2023
@ozyx
fix(#7234): 'Remove Container' button not working in Flexible Layout …
cdd772a 
…toolbar (#7240)

* refactor: rename prop for clarity

- `orientation` -> `dragOrientation`

* fix(#7234): fix event name for flexible layout toolbar action

* test(e2e): add tests for flexible layout toolbar actions

* test: add `@localStorage` tags
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 16, 2023
@davetsay davetsay reopened this Nov 16, 2023
@davetsay
Copy link
Contributor

Re-opening because remove frame still does not work. Remove container was fixed.

@unlikelyzero unlikelyzero modified the milestones: Target:3.2.0, Target:3.3.0 Nov 16, 2023
@ozyx ozyx mentioned this issue Nov 17, 2023
Merged
15 tasks
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:3.2.0 Nov 17, 2023
ozyx added a commit that referenced this issue Nov 17, 2023
@ozyx
fix(#7234): Fix frame deletion in Flexible Layouts (#7244)
b9ae461 
* fix: use the correct event name for frame deletion

* test: add test for frame removal

* refactor: update test locators, add a11y

* test: upgrade locator

* test: assert dialog text
@unlikelyzero unlikelyzero modified the milestones: Target:3.2.0, Target:3.3.0 Dec 4, 2023
@charlesh88
Copy link
Contributor

charlesh88 commented Dec 4, 2023 •
edited by unlikelyzero
Loading

Testathon 2023-12-04: Partially verified and filed #7274

@khalidadil
Copy link
Contributor

khalidadil commented Dec 4, 2023 •
edited
Loading

Verified in Testathon on 12/04/23. I'm seeing the same thing as Charles, with the "remove frame" button showing even if there's a single frame in the container. Otherwise, frames and container can now be removed.

@ozyx ozyx added the verified Tested or intentionally closed label Jan 17, 2024
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
6 participants
@charlesh88 @khalidadil @davetsay @ozyx @unlikelyzero @rukmini-bose