fix(#7234): 'Remove Container' button not working in Flexible Layout toolbar #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 159 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/16/2023 02:08:46am UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 46 runsfailed over last 7 days |
28.26% (13)13 / 46 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 47 runsfailed over last 7 days |
40.43% (19)19 / 47 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 47 runsfailed over last 7 days |
57.45% (27)27 / 47 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
0% (0)0 / 47 runsfailed over last 7 days |
25.53% (12)12 / 47 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.27% (1)1 / 79 runfailed over last 7 days |
55.70% (44)44 / 79 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 47 runsfailed over last 7 days |
70.21% (33)33 / 47 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/16/2023 02:08:46am UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 9df3f97
Started: 11/16/2023 02:02:06am UTC
⚠️ Flakes
📄 functional/couchdb.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1 • Initial Attempt |
0% (0)0 / 28 runsfailed over last 7 days |
17.86% (5)5 / 28 runsflaked over last 7 days |
|
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1 • Initial Attempt |
0% (0)0 / 28 runsfailed over last 7 days |
3.57% (1)1 / 28 runflaked over last 7 days |
scottbell
approved these changes
Nov 16, 2023
| type: 'issue', | ||
| description: 'https://github.com/nasa/openmct/issues/7234' | ||
| }); | ||
| await page.locator('div:nth-child(5) > .c-fl-container__frames-holder').click(); |
There was a problem hiding this comment.
forgive me John for I have sinned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7234
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist