-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Expanded View" for timelist for Situational Awareness dashboards #7377
Comments
Note that the title of this issue is misleading; this actually adds a "expanded" view to the Time List object. "Compact" view is used now to refer to the older original Time List view. Testing Instructions:Expanded View
Activity Details and Statuses
Reference FilesExpanded Activity example 1Expanded Activity example 2Activity statuses, timeframes and time context text |
* Add activity states domain object and interceptor to auto create one * Add activity state inspector option * Only save status if we have a unique ids for activities * Include the id in the activity properties * Don't show activity state section in the inspector if multiple activities are selected * Display activity properties when an activity row is selected in the timelist * Add compact view for timelist * Add inspector configuration for compact view * Set colors based on time relation of activity * Use activity id as key if it is available * Ensure the correct option is selected for activity states * Closes #7377 - Markup and CSS sanding and polishing. - Still WIP! * Closes #7377 - Markup and CSS sanding and polishing. - Still WIP! * Add status label * Rename to Expanded view and isExpanded as properties. Add display style dropdown configuration in the inspector. * Refactor activity selection. Display activity properties * Closes #7377 - Label formatting Todo notes about states. - Computed values and `v-ifs` added to control display for progress pie and countdown 'hero'. - Still WIP! * Closes #7377 - Add svg icons and some stubbed in logic. - Still WIP! * Remove activity states plugin. Move the activity states interceptor to the plan plugin. * Change activity states interceptor parameters to options * Rename constants * Fix activity states test * Addresses review comments making code more readable. * Closes #7377 - Significant adds for large Time List element styling for activity states. - `$color*` Time List-related theme constants remapped and significantly enhanced. - Code cleanup and removal of stubbed-in SCSS vars. * Closes #7377 - Unit testing and colors in Snow in progress. - Fixed erroneous checkin in ExpandedViewItem.vue. * Remove ExpandedView component and pull the ExpandedViewItem up to the top level. Same for ListView, pulling the ListItem up one level. * Fix sorting for compact view. Hardcode options for switching compact/expanded views. * Closes #7377 - Snow Time List colors finalized and smoke tested. - New graphic SVG for skipped activity. - Added aria labels to SVG graphics. * Closes #7377 - Fixed div with no class. * Add e2e test for activity states feature. * Address review comments. Rename variables, documentation. * No shallow copy * Merge updates to activity-state * Sync with activity states PR * Draft of progress-pie * - Add `s-selected` styling for Expanded Time List elements. * Add 2 new date formats * Look and feel enhancements for pie, zero duration events and start and end time formats * Fix pie show/hide condition * Final touches to the pie and labels * Refactor label logic * Closes #7377 - Added `sweep-hand` animation element to progress pie graphic SVG. * Remove use of ListView - no point passing arrays around since we are already using sortedItems and itemProperties for expandedViewItems * We addded a new column for duration and changed the previous duration to countdown. This required adjustment of the test * Fix expanded view for timelist tests * Closes #7377 - Fixed display logic for inferred execution states. * Closes #7377 - Fixed a bug that threw console errors when a value was undefined. * Optimize rendering of timelist activities * Remove focused test * Address review comments * Remove reactive selection for plan activities * destructure props into individual item properties for render performance benefits * Use local variables and remove JSON utility methods * Change cancelled to skipped * Focus the activity tab when shown * Fix label updates * Add countup to cspell * Remove progress pie due to licensing unknowns --------- Co-authored-by: Charles Hacskaylo <[email protected]> Co-authored-by: Charles Hacskaylo <[email protected]>
Testathon 2/27/2024: waiting on #7485 |
#7485 Is now fixed. |
I noticed in testing that changing the status of one activity sometimes affected other activities. I don't know if this is by design and simply due to some logic that I am just not aware of? It didn't happen with every activity. See video below - Screen.Recording.2024-03-14.at.5.07.42.PM.mov |
This is a bug in the planning tool. Activities that were copied appear to have the same uuid in the plan. I will raise this with the planning tools team. |
In that case, verified. |
Testathon 2024-03-19: all test instructions run through, verified fixed. |
Describe the solution you'd like
As part of the situational awareness work, we need a compact view of the time list view so it can be included in a dashboard.
This compact view will have minimum needed information and widgets for easier visualization of activities.
The design for compact view can be found on confluence page "Situational Awareness Needs and Design"
The text was updated successfully, but these errors were encountered: