d3 implementation of progress pie chart #7485

shefalijoshi · 2024-02-07T21:34:52Z

Describe your changes:

Use the d3.arc API to draw pie progress
-driveby to fix some of the flaky percy tests
-driveby to add a mission percy test

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Has this been smoke tested?
Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
Have you associated a milestone with this PR? Note: leave blank if unsure.
Is this a breaking change to be called out in the release notes?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?

codecov · 2024-02-07T21:40:59Z

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.28%. Comparing base (ef62633) to head (b7628e7).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7485      +/-   ##
==========================================
+ Coverage   55.24%   55.28%   +0.03%     
==========================================
  Files         672      673       +1     
  Lines       26965    26994      +29     
  Branches     2622     2623       +1     
==========================================
+ Hits        14898    14924      +26     
- Misses      11346    11351       +5     
+ Partials      721      719       -2

Flag	Coverage Δ
e2e-full	`23.30% <16.00%> (-0.02%)`	⬇️
e2e-stable	`59.61% <100.00%> (+0.08%)`	⬆️
unit	`48.50% <15.38%> (-0.04%)`	⬇️

Files	Coverage Δ
src/plugins/timelist/TimelistComponent.vue	`61.80% <ø> (ø)`
src/plugins/timelist/svg-progress.js	`100.00% <100.00%> (ø)`
src/plugins/timelist/ExpandedViewItem.vue	`4.68% <0.00%> (-0.32%)`	⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef62633...b7628e7. Read the comment docs.

charlesh88

The pie isn't displaying properly at 0% (yellow arrow) and 100% (orange arrow).

At 0%, it's displaying a very thin sliver of progress, but shouldn't.
At 100%, it's displaying a very thin sliver of "incompleteness", but shouldn't.

This may be due to not "rounding" things properly; I had to deal with this in the previous code when progress was near 100%: if the amount of remaining update (in terms of percent) was less than the percent-update-per-tick, my version was always stalling and never getting to 100%. I added a test to check if the remaining percent < the percent-update-per-tick, and if so, directly set the percentage to 100%.

Maybe there's a related thing near 0?

shefalijoshi · 2024-02-12T18:20:36Z

The pie isn't displaying properly at 0% (yellow arrow) and 100% (orange arrow).
* At 0%, it's displaying a very thin sliver of progress, but shouldn't.

* At 100%, it's displaying a very thin sliver of "incompleteness", but shouldn't.
This may be due to not "rounding" things properly; I had to deal with this in the previous code when progress was near 100%: if the amount of remaining update (in terms of percent) was less than the percent-update-per-tick, my version was always stalling and never getting to 100%. I added a test to check if the remaining percent < the percent-update-per-tick, and if so, directly set the percentage to 100%.

Maybe there's a related thing near 0?

0% works now:

Screen.Recording.2024-02-12.at.10.14.11.AM.mov

and so does 100%:

Screen.Recording.2024-02-12.at.10.16.40.AM.mov

- Minor tweaks to `s-selected` styling.

charlesh88

0 and 100% pie issues addressed, looks great!

… redo-pie-chart

charlesh88 · 2024-02-14T17:06:01Z

This is ready to ship! My name is @charlesh88 and I approve this message.

unlikelyzero · 2024-02-22T00:01:57Z

let's make sure we have coverage

unlikelyzero

Need the simplest visual test

…e-chart

…t least one clock tick. Write tests for progress pie

… redo-pie-chart

e2e/tests/functional/planning/timelist.e2e.spec.js

… redo-pie-chart

e2e/tests/functional/planning/timelist.e2e.spec.js

…e-chart

ozyx

LGTM! Great job on the tests

unlikelyzero · 2024-03-05T00:43:47Z

e2e/constants.js

@@ -17,3 +17,9 @@ export const MISSION_TIME = 1732413600000; // Saturday, November 23, 2024 6:00:0
 */
 export const VISUAL_URL =
  './#/browse/mine?tc.mode=fixed&tc.startBound=1693592063607&tc.endBound=1693593893607&tc.timeSystem=utc&view=grid&hideInspector=true&hideTree=true';
+
+/**


@shefalijoshi can you update this?

d3 implementation of progress pie chart

f7cfa3e

shefalijoshi requested a review from charlesh88 February 7, 2024 21:36

ozyx added this to the Target:4.0.0 milestone Feb 8, 2024

ozyx added the type:feature Feature. Required intentional design label Feb 8, 2024

charlesh88 requested changes Feb 8, 2024

View reviewed changes

shefalijoshi requested a review from charlesh88 February 12, 2024 18:21

shefalijoshi and others added 2 commits February 12, 2024 10:22

Handle 0% and 100% cases

cf64869

PR #7485

77a3692

- Minor tweaks to `s-selected` styling.

charlesh88 approved these changes Feb 12, 2024

View reviewed changes

shefalijoshi added 3 commits February 12, 2024 15:02

add in-progress class for compact view

42f45af

Merge branch 'redo-pie-chart' of https://github.com/nasa/openmct into…

b1f1cf3

… redo-pie-chart

Merge branch 'master' into redo-pie-chart

6cbcf7a

Merge branch 'master' into redo-pie-chart

729e2b4

ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 21, 2024

ozyx enabled auto-merge (squash) February 21, 2024 23:37

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 21, 2024

unlikelyzero disabled auto-merge February 22, 2024 00:01

unlikelyzero self-assigned this Feb 22, 2024

unlikelyzero self-requested a review February 22, 2024 00:15

unlikelyzero requested changes Feb 22, 2024

View reviewed changes

rukmini-bose mentioned this pull request Feb 27, 2024

Add "Expanded View" for timelist for Situational Awareness dashboards #7377

Closed

shefalijoshi added 2 commits February 29, 2024 10:55

Merge branch 'master' of https://github.com/nasa/openmct into redo-pi…

5f8aaab

…e-chart

Fix issue where updating progress for pie chart wasn't working till a…

557f8f9

…t least one clock tick. Write tests for progress pie

shefalijoshi requested a review from unlikelyzero March 1, 2024 15:30

unlikelyzero added 2 commits March 4, 2024 07:38

update documentation for clock annotation

651665f

Update clock annotation in tests

3acd37c

unlikelyzero added 5 commits March 4, 2024 07:40

split long testfile

a96fbbe

driveby missing test

c8944dc

driveby fix flake

8682974

temp: fix flake and prep for visual test

b68a35a

Merge branch 'redo-pie-chart' of https://github.com/nasa/openmct into…

1b4e368

… redo-pie-chart

github-advanced-security bot found potential problems Mar 4, 2024

View reviewed changes

e2e/tests/functional/planning/timelist.e2e.spec.js Fixed Show fixed Hide fixed

shefalijoshi and others added 4 commits March 4, 2024 11:20

Fix linting errors

20e0973

Merge branch 'master' into redo-pie-chart

08dd7c1

this should be resolved

6129034

Merge branch 'redo-pie-chart' of https://github.com/nasa/openmct into…

f516a76

… redo-pie-chart

github-advanced-security bot found potential problems Mar 4, 2024

View reviewed changes

e2e/tests/functional/planning/timelist.e2e.spec.js Fixed Show fixed Hide fixed

unlikelyzero and others added 10 commits March 4, 2024 15:30

these keep popping up

4107a9b

moving some of this around

998279c

moving this around

b326577

the test

217b430

Merge branch 'master' of https://github.com/nasa/openmct into redo-pi…

7284c47

…e-chart

Merge branch 'master' of https://github.com/nasa/openmct into redo-pi…

f891c23

…e-chart

Fix imports for tests

ead0127

no longer need constant

289465d

move to front

3853d17

Stabalize name

910b683

ozyx self-requested a review March 5, 2024 20:03

test(missionStatus): fix visual test

b7628e7

ozyx approved these changes Mar 5, 2024

View reviewed changes

unlikelyzero approved these changes Mar 5, 2024

View reviewed changes

unlikelyzero merged commit df96972 into master Mar 5, 2024
29 of 38 checks passed

unlikelyzero deleted the redo-pie-chart branch March 5, 2024 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d3 implementation of progress pie chart #7485

d3 implementation of progress pie chart #7485

shefalijoshi commented Feb 7, 2024 •

edited

Loading

codecov bot commented Feb 7, 2024 •

edited

Loading

charlesh88 left a comment •

edited

Loading

shefalijoshi commented Feb 12, 2024

charlesh88 left a comment

charlesh88 commented Feb 14, 2024

unlikelyzero commented Feb 22, 2024

unlikelyzero left a comment

ozyx left a comment

unlikelyzero Mar 5, 2024

d3 implementation of progress pie chart #7485

d3 implementation of progress pie chart #7485

Conversation

shefalijoshi commented Feb 7, 2024 • edited Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Feb 7, 2024 • edited Loading

Codecov Report

charlesh88 left a comment • edited Loading

Choose a reason for hiding this comment

shefalijoshi commented Feb 12, 2024

charlesh88 left a comment

Choose a reason for hiding this comment

charlesh88 commented Feb 14, 2024

unlikelyzero commented Feb 22, 2024

unlikelyzero left a comment

Choose a reason for hiding this comment

ozyx left a comment

Choose a reason for hiding this comment

unlikelyzero Mar 5, 2024

Choose a reason for hiding this comment

shefalijoshi commented Feb 7, 2024 •

edited

Loading

codecov bot commented Feb 7, 2024 •

edited

Loading

charlesh88 left a comment •

edited

Loading