Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide own renderWhenVisible function since manually creating an object view #7281

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Dec 7, 2023

Fixes #7283

Describe your changes:

Provide renderWhenVisible function to plot object

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

Copy link

deploysentinel bot commented Dec 7, 2023

Current Playwright Test Results Summary

✅ 164 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/07/2023 01:43:57am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 6d1c311

Started: 12/07/2023 01:36:05am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
32.76% (19) 19 / 58 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 57 runs
failed over last 7 days
43.86% (25) 25 / 57 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.75% (1) 1 / 57 run
failed over last 7 days
40.35% (23) 23 / 57 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
5.06% (4) 4 / 79 runs
failed over last 7 days
65.82% (52) 52 / 79 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.72% (1) 1 / 58 run
failed over last 7 days
62.07% (36) 36 / 58 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 15 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/07/2023 01:43:57am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 6d1c311

Started: 12/07/2023 01:36:13am UTC

View Detailed Build Results


Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #7281 (6d1c311) into master (93e5219) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7281      +/-   ##
==========================================
- Coverage   55.97%   55.91%   -0.06%     
==========================================
  Files         655      655              
  Lines       26290    26297       +7     
  Branches     2540     2541       +1     
==========================================
- Hits        14715    14704      -11     
- Misses      10867    10885      +18     
  Partials      708      708              
Flag Coverage Δ
e2e-full 41.85% <ø> (ø)
e2e-stable 58.34% <ø> (-0.10%) ⬇️
unit 49.22% <0.00%> (-0.01%) ⬇️
Files Coverage Δ
...ctorDataVisualization/NumericDataInspectorView.vue 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e5219...6d1c311. Read the comment docs.

@davetsay davetsay marked this pull request as ready for review December 8, 2023 17:14
@scottbell scottbell merged commit 9ed8d4f into master Dec 8, 2023
16 of 26 checks passed
@scottbell scottbell deleted the fix/renderWhenVisible-does-not-exist branch December 8, 2023 17:33
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 12, 2023
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data inspector visualization missing renderWhenVisible
3 participants