Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for inspector data pivoting #7282

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Dec 7, 2023

Closes #7283

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link

deploysentinel bot commented Dec 7, 2023

Current Playwright Test Results Summary

✅ 15 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/19/2023 10:31:25am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: c39c8aa

Started: 12/19/2023 10:29:42am UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 166 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/19/2023 10:31:25am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c39c8aa

Started: 12/19/2023 01:07:29am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
1.39% (1) 1 / 72 run
failed over last 7 days
26.39% (19) 19 / 72 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
2.74% (2) 2 / 73 runs
failed over last 7 days
36.99% (27) 27 / 73 runs
flaked over last 7 days

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
1.43% (1) 1 / 70 run
failed over last 7 days
8.57% (6) 6 / 70 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.43% (1) 1 / 70 run
failed over last 7 days
55.71% (39) 39 / 70 runs
flaked over last 7 days

View Detailed Build Results


Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #7282 (c39c8aa) into master (0ce36c8) will decrease coverage by 0.12%.
The diff coverage is 52.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7282      +/-   ##
==========================================
- Coverage   55.79%   55.67%   -0.12%     
==========================================
  Files         655      658       +3     
  Lines       26327    26364      +37     
  Branches     2544     2546       +2     
==========================================
- Hits        14688    14679       -9     
- Misses      10934    10984      +50     
+ Partials      705      701       -4     
Flag Coverage Δ *Carryforward flag
e2e-full 41.86% <ø> (+<0.01%) ⬆️ Carriedforward from 0ce36c8
e2e-stable 58.59% <95.23%> (+0.20%) ⬆️
unit 48.66% <2.63%> (-0.38%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
example/dataVisualization/plugin.js 100.00% <100.00%> (ø)
...lization/InspectorDataVisualizationViewProvider.js 100.00% <100.00%> (+100.00%) ⬆️
src/plugins/plugins.js 100.00% <100.00%> (ø)
...tion/ExampleDataVisualizationSourceViewProvider.js 90.90% <90.90%> (ø)
...tion/components/ExampleDataVisualizationSource.vue 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce36c8...c39c8aa. Read the comment docs.

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 14, 2023
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 14, 2023
@scottbell
Copy link
Contributor Author

To test, please see this ticket:
#7283 (comment)

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 15, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 15, 2023
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hero we needed, @scottbell

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@scottbell scottbell merged commit ec910dc into master Dec 19, 2023
21 checks passed
@scottbell scottbell deleted the 7060-inspector-data-pivoting-api-needs-tests-and-readmemd branch December 19, 2023 10:33
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data inspector visualization missing renderWhenVisible Inspector Data Pivoting API needs tests and README.md
3 participants