-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7215)[Fault Management]: Fix shelving and acknowledging faults with single and bulk actions #7559
Merged
fix(#7215)[Fault Management]: Fix shelving and acknowledging faults with single and bulk actions #7559
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0192048
refactor: merge FaultManagementListView into FaultManagementView
ozyx b1a24b2
refactor: make `selectedFaults` a computed property
ozyx 53b6880
refactor: use named exports
ozyx a42177f
fix: reset fault map AFTER selectedFaults have been acknowledged
ozyx 3caca5c
a11y: add aria labels for fault management toolbar buttons
ozyx 37656da
refactor: use named import/exports
ozyx 3f97a27
a11y: add label
ozyx 4895b6a
a11y: add aria label for checkboxes
ozyx 2746de3
fix: acknowledging or shelving single fault from context menu should …
ozyx e16d6a6
refactor: use change event instead of input event for checkbox
ozyx 504c8dd
test: fix e2e tests, remove expect.softs
ozyx 7399fc1
test: stabilize fault management e2e tests
ozyx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gross
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep but i'd rather this than have to restructure all of fault management