Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable a11y checks in visual suite-- minus planning tests #7747

Merged
merged 16 commits into from
Jun 19, 2024

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Jun 13, 2024

Addresses #7421 (does not close it)
Closes #7317

Describe your changes:

We disabled a11y checks to get build9 out the door. This re-enables most of them, but leaves the PLAN failures alone.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.64%. Comparing base (34b4091) to head (c25f9e5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7747      +/-   ##
==========================================
- Coverage   57.05%   56.64%   -0.41%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15506    15395     -111     
- Misses      11342    11451     +109     
- Partials      329      331       +2     
Flag Coverage Δ
e2e-full 23.57% <ø> (-18.55%) ⬇️
e2e-stable 60.63% <ø> (+<0.01%) ⬆️
unit 49.25% <ø> (-0.17%) ⬇️

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b4091...c25f9e5. Read the comment docs.

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jun 18, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Jun 18, 2024
@unlikelyzero unlikelyzero marked this pull request as ready for review June 18, 2024 21:03
@unlikelyzero unlikelyzero linked an issue Jun 18, 2024 that may be closed by this pull request
@unlikelyzero unlikelyzero self-requested a review June 18, 2024 21:35
@unlikelyzero unlikelyzero requested a review from ozyx June 18, 2024 21:35
@ozyx ozyx changed the title Enable A11y tests chore: re-enable a11y checks in visual suite Jun 18, 2024
@ozyx ozyx enabled auto-merge (squash) June 19, 2024 01:11
@ozyx ozyx changed the title chore: re-enable a11y checks in visual suite chore: re-enable a11y checks in visual suite-- minus planning tests Jun 19, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 19, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 19, 2024
@ozyx ozyx merged commit a577081 into master Jun 19, 2024
24 checks passed
@ozyx ozyx deleted the undo-7421 branch June 19, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] a11y reports are no longer being written to disk
3 participants