-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: re-enable a11y checks in visual suite-- minus planning tests #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7747 +/- ##
==========================================
- Coverage 57.05% 56.64% -0.41%
==========================================
Files 673 673
Lines 27177 27177
Branches 2636 2636
==========================================
- Hits 15506 15395 -111
- Misses 11342 11451 +109
- Partials 329 331 +2
see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
approved these changes
Jun 18, 2024
ozyx
changed the title
chore: re-enable a11y checks in visual suite
chore: re-enable a11y checks in visual suite-- minus planning tests
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7421 (does not close it)
Closes #7317
Describe your changes:
We disabled a11y checks to get build9 out the door. This re-enables most of them, but leaves the PLAN failures alone.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist