Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] re-enable and fix all failing plan tests #7753

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Jun 20, 2024

Addresses #7421 (does not close it)
Closes

Describe your changes:

  • enable a11y plan suite
  • fix contrast issues that were causing the tests to fail

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.64%. Comparing base (a577081) to head (3634ca7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7753      +/-   ##
==========================================
- Coverage   56.94%   56.64%   -0.31%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15477    15394      -83     
- Misses      11369    11451      +82     
- Partials      331      332       +1     
Flag Coverage Δ
e2e-full 23.57% <ø> (-18.51%) ⬇️
e2e-stable 60.63% <ø> (+<0.01%) ⬆️
unit 49.25% <ø> (-0.02%) ⬇️

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a577081...3634ca7. Read the comment docs.

@unlikelyzero unlikelyzero marked this pull request as ready for review June 21, 2024 18:42
@unlikelyzero unlikelyzero added severity:critical type:maintenance tests, chores, or project maintenance pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e:perf Trigger perf tests labels Jun 21, 2024
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jun 21, 2024
@github-actions github-actions bot removed pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e:perf Trigger perf tests labels Jun 21, 2024
@unlikelyzero unlikelyzero merged commit 554f77c into master Jun 21, 2024
33 of 45 checks passed
@unlikelyzero unlikelyzero deleted the enable-plan-a11y branch June 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants