Fix stackage#4312: Relax network version bound. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: commercialhaskell/stackage#4312 Should be safe for us to relax bound as upstream `mysql-haskell` library has already safely relaxed its bound. Tested with the following `stack.yaml`: ```yaml resolver: lts-10.4 packages: - ./persistent - ./persistent-template - ./persistent-sqlite - ./persistent-test - ./persistent-mongoDB - ./persistent-mysql - ./persistent-mysql-haskell - ./persistent-postgresql - ./persistent-redis - ./persistent-qq extra-deps: - monad-logger-0.3.28.1 - mysql-simple-0.4.4 - mono-traversable-1.0.8.1 - unliftio-0.2.4.0 - unliftio-core-0.1.1.0 - async-2.1.1.1 - typed-process-0.2.1.0 - resourcet-1.1.11 - network-3.0.0.0 # - network-2.6.3.6 - tcp-streams-1.0.1.1 - io-streams-1.5.1.0 - mysql-haskell-0.8.4.2 ```
hvr
reviewed
Jan 29, 2019
| @@ -42,7 +42,7 @@ library | |||
| -- keep the following in sync with @mysql-haskell@ .cabal | |||
| , io-streams >= 1.2 && < 2.0 | |||
| , time >= 1.5.0 | |||
| , network >= 2.3 && < 3.0 | |||
| , network >= 2.3 && < 4.0 | |||
There was a problem hiding this comment.
Note that network follows the PVP and not SemVer and therefore this upper bound makes no sense; see also https://pvp.haskell.org/faq/#how-does-the-pvp-relate-to-semantic-versioning-semver
IOW, the proper upper bounds for such packages (see also io-streams above) is
build-depends: network (>= 2.3 && < 2.9) || (>= 3 && < 3.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: commercialhaskell/stackage#4312