Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stackage#4312: Relax network version bound. #10

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Fix stackage#4312: Relax network version bound. #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0821a5a
Address VSCode linter issues.
naushadh Jan 29, 2019
bc187ef
Fix stackage#4312: Relax network version bound.
naushadh Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions persistent-mysql-haskell/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
# ChangeLog for `persistent-mysql-haskell`

## 0.5.2

- Fix [stackage#4312](https://github.com/commercialhaskell/stackage/issues/4312): Relax `network` version bound.

## 0.5.1

- [#9](https://github.com/naushadh/persistent/pull/9) Add `insertEntityOnDuplicateKeyUpdate` and `insertEntityManyOnDuplicateKeyUpdate` functions


## 0.5.0

- Port [#812](https://github.com/yesodweb/persistent/pull/812) from `persistent-mysql`: Add support for SQL isolation levels
Expand All @@ -26,47 +29,59 @@
- [#760](https://github.com/yesodweb/persistent/pull/760) Rename SomeField type to HandleUpdateCollision.

## 0.3.6

- Port [#752](https://github.com/yesodweb/persistent/pull/754) from `persistent-mysql`: Fix mysql sqltype migrations.

## 0.3.5

- Updated `selectSource` implementation to stream results instead of loading everything into memory.

## 0.3.4.1

- Fix a haddock issue down-streamed from [#693](https://github.com/yesodweb/persistent/pull/693).

## 0.3.4

- Port [#693](https://github.com/yesodweb/persistent/pull/693) from `persistent-mysql`: Extend the `SomeField` type to allow `insertManyOnDuplicateKeyUpdate` to conditionally copy values.
- Port [#702](https://github.com/yesodweb/persistent/pull/702) from `persistent-mysql`: Fix behavior of `insertManyOnDuplicateKeyUpdate` to ignore duplicate key exceptions when no updates specified.
- Bumped TLS bounds to be in [sync with `mysql-haskell`](https://github.com/winterland1989/mysql-haskell/pull/15) and land ourselves [back on stackage](https://github.com/fpco/stackage/pull/2956).

## 0.3.3

- Port from `persistent-mysql`: MySQL on duplicate key update [#674](https://github.com/yesodweb/persistent/pull/674).

## 0.3.2.1

- Port from `persistent-mysql`: Prevent spurious no-op migrations when `default=NULL` is specified - revised version [#672](https://github.com/yesodweb/persistent/pull/672) (which fixes bug [#671](https://github.com/yesodweb/persistent/issues/671) introduced by the earlier attempt [#641](https://github.com/yesodweb/persistent/pull/641)).

## 0.3.2.0

- Added conditional declaration of `Show` instance for mysql-haskell's `ConnectInfo` for compatibility with `mysql-haskell-0.8.1.0+`.

## 0.3.1.0

- Fixed compiler warnings in `stack --pedantic` mode so the project can run upstream tests on Travis.
- Minor README enhancements for badges and fixed URL for example when viewing outside of Github.

## 0.3.0.0

- Added API for setting [TLS client parameters](https://hackage.haskell.org/package/mysql-haskell-0.8.0.0/docs/Database-MySQL-TLS.html) for secure MySQL connections.
- Exported [Data.TLSSetting](https://hackage.haskell.org/package/tcp-streams-1.0.0.0/docs/Data-TLSSetting.html) for convenient usage of TLS.

## 0.2.1.0

- Bumped up version to update README.

## 0.2.0.0

- Added APIs for setting port number and character encoding.
- Updated type signature for mkMySQLConnectInfo to align with mysql-haskell.

## 0.1.1.0

- Bumped up version to include README and example.

## 0.1.0.0

* Ported persistent-mysql 2.6 to use mysql-haskell as the underlying database driver.
* Deprecated MySQLConf and ConnectInfo native constructor and default instance in favor of mk functions for better forward compatibility. See http://www.snoyman.com/blog/2016/11/designing-apis-for-extensibility.
- Ported persistent-mysql 2.6 to use mysql-haskell as the underlying database driver.
- Deprecated MySQLConf and ConnectInfo native constructor and default instance in favor of mk functions for better forward compatibility. See http://www.snoyman.com/blog/2016/11/designing-apis-for-extensibility.
4 changes: 2 additions & 2 deletions persistent-mysql-haskell/persistent-mysql-haskell.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: persistent-mysql-haskell
version: 0.5.1
version: 0.5.2
license: MIT
license-file: LICENSE
author: Naushadh <[email protected]>, Felipe Lessa <[email protected]>, Michael Snoyman
Expand Down Expand Up @@ -42,7 +42,7 @@ library
-- keep the following in sync with @mysql-haskell@ .cabal
, io-streams >= 1.2 && < 2.0
, time >= 1.5.0
, network >= 2.3 && < 3.0
, network >= 2.3 && < 4.0
Copy link

@hvr hvr Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that network follows the PVP and not SemVer and therefore this upper bound makes no sense; see also https://pvp.haskell.org/faq/#how-does-the-pvp-relate-to-semantic-versioning-semver

IOW, the proper upper bounds for such packages (see also io-streams above) is

build-depends: network (>= 2.3 && < 2.9) ||  (>= 3 && < 3.1)

, tls >= 1.3.5 && < 1.5
exposed-modules: Database.Persist.MySQL
other-modules: Database.Persist.MySQLConnectInfoShowInstance
Expand Down