Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fikset typefeil introdusert i v2.0.6 for ikoner og loader #1759

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 23, 2023

React v18 har lagt til noen ekstra typer i SVGSVGElement. tsc velger å destrukturere props som bruker SVGSVGElement ved build, noe som gjør at alle ikonene våre + loader ender opp med å inneholde react 18 spesifikke typer. Dette brekker for alle som ikke bruker @types/react: ^18

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

Chromatic build-output:

commit: 0b79e2faf

@KenAJoh KenAJoh changed the title 🐛 Fiket typefeil for ikoner og loader 🐛 Fikset typefeil introdusert i v2.0.6 for ikoner og loader Jan 24, 2023
@KenAJoh KenAJoh merged commit dcf5cfc into master Jan 24, 2023
@KenAJoh KenAJoh deleted the bug/types-icons branch January 24, 2023 10:35
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant