Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆙 Minor-oppgradering av deps #2795

Merged
merged 5 commits into from
Mar 18, 2024
Merged

🆙 Minor-oppgradering av deps #2795

merged 5 commits into from
Mar 18, 2024

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Mar 15, 2024

Hadde vært artig å teste om vi også kan fjerne den workarounden på Loader nå, ref #1759

Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: 572dd42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Storybook demo

Endringer til review: 3

368a0f89a | 60 komponenter | 225 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented Mar 15, 2024

https://www.chromatic.com/test?appId=5f801fb2aea7820022de2936&id=65f4499474b26f62ee48e6bc 🤔 Er det storybook som har oppdatert inline-code styling?

@KenAJoh
Copy link
Collaborator

KenAJoh commented Mar 18, 2024

Får denne nå 🤔 Ser ikke ut som vi gjør noe feil på vår side, så kanskje noe med nye ts-versjoner og sanity. Kan hende vi må oppgradere noen sanity-versjoner i samme slengen

./sanity/plugins/god-praksis-taxonomy/documents/innholdstype.ts:18:7
Type error: Object literal may only specify known properties, and 'rows' does not exist in type '{ type: string; name: string; } & TypeAliasDefinition<string, "string" | "number" | "boolean" | "object" | "slug" | "url" | "code" | "block" | "image" | "text" | "document" | "color" | "file" | "date" | ... 6 more ... | undefined> & { ...; } & FieldDefinitionBase'.

  16 |       title: "Beskrivelse",
  17 |       type: "text",
> 18 |       rows: 3,
     |       ^
  19 |     }),
  20 |   ],
  21 |   orderings: [

sanity-type

/** @public */
export declare interface TextDefinition extends BaseSchemaDefinition {
  type: 'text'
  rows?: number
  options?: TextOptions
  placeholder?: string
  validation?: ValidationBuilder<TextRule, string>
  initialValue?: InitialValueProperty<any, string>
}

@HalvorHaugan
Copy link
Contributor Author

Oppgraderte minor-versjoner på nytt, og nå funker det hos meg. Funker det hos deg?

@KenAJoh
Copy link
Collaborator

KenAJoh commented Mar 18, 2024

Oppgraderte minor-versjoner på nytt, og nå funker det hos meg. Funker det hos deg?

Får fortsatt feil 😞 (slettet node-modules etc)

@HalvorHaugan
Copy link
Contributor Author

Hva med nå? Tror problemet var at det var ulike versjoner av @sanity/types. Oppgradering av sanity løste det.

@HalvorHaugan HalvorHaugan added the ignore-chromatic Hindrer kode i å bli testet med chromatic label Mar 18, 2024
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funker nå 🎉 Bumpet sanity vision, schema og block-tools i samme slengen til samme minor

@HalvorHaugan HalvorHaugan merged commit aebba20 into main Mar 18, 2024
3 checks passed
@HalvorHaugan HalvorHaugan deleted the minor-up branch March 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-chromatic Hindrer kode i å bli testet med chromatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants