Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use Serillize never to not output sensitive data #216

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

syphax-bouazzouni
Copy link

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (c8c78d4) to head (0926cd4).
Report is 54 commits behind head on develop.

Files with missing lines Patch % Lines
lib/ontologies_linked_data/models/base.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
+ Coverage    77.80%   78.75%   +0.94%     
===========================================
  Files           74       74              
  Lines         5276     5380     +104     
===========================================
+ Hits          4105     4237     +132     
+ Misses        1171     1143      -28     
Flag Coverage Δ
unittests 78.75% <50.00%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr changed the base branch from master to develop October 1, 2024 06:48
@alexskr
Copy link
Member

alexskr commented Oct 2, 2024

Thanks for the PR.
Unit tests should be added for the serialization of sensitive data.

@alexskr
Copy link
Member

alexskr commented Oct 2, 2024

we will add unit test in the ontologies_api

@alexskr alexskr merged commit 812dd78 into ncbo:develop Oct 2, 2024
3 of 4 checks passed
mdorf added a commit to ncbo/ontologies_api that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants