Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add apple-native, windows-native, sync-secret-service feature in dep:keyring #390

Closed

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Aug 15, 2024

No description provided.

@dj8yfo dj8yfo changed the title chore: add sync-secret-service feature in dep:keyring (for linux support) chore: add apple-native, windows-native, sync-secret-service feature in dep:keyring Aug 15, 2024
@dj8yfo dj8yfo marked this pull request as ready for review August 15, 2024 13:15
@dj8yfo
Copy link
Contributor Author

dj8yfo commented Aug 15, 2024

@race-of-sloths ping

@race-of-sloths
Copy link

race-of-sloths commented Aug 15, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
We are launching a survey "Who is faster? You vs SpaceX"

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Collaborator

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just think if it can fail on other platforms cause of all the features we pull together

@frol
Copy link
Collaborator

frol commented Aug 15, 2024

@akorchyn CI passed, so we are good. CI here builds all the binaries and you can even download them to test: https://github.com/near/near-cli-rs/actions/runs/10404198827?pr=390 (please, test it)

Copy link
Collaborator

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could manage to sing tx on NixOS. But I have compiled on my own, because using precompiled binaries is tricky :)

@akorchyn
Copy link
Collaborator

@race-of-sloths score 5

@akorchyn akorchyn self-requested a review August 15, 2024 14:16
@frol
Copy link
Collaborator

frol commented Aug 15, 2024

I am closing this one in favor of #392

@frol frol closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants