Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed native operating system keychain support #392

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

frol
Copy link
Collaborator

@frol frol commented Aug 15, 2024

After a recent upgrade of keyring from 2.x to 3.x, all the features became disabled by default instead of enabled by default, so we have to enable them back again.

@race-of-sloths invite

@race-of-sloths
Copy link

race-of-sloths commented Aug 15, 2024

@frol Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
We are launching a survey "Who is faster? You vs SpaceX"

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@akorchyn 3

Your contribution is much appreciated with a final score of 3!
You have received 30 Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol
Copy link
Collaborator Author

frol commented Aug 15, 2024

I have tested it on MacOS and Ubuntu 22.04 (server) and Ubuntu 24.04 (in Docker) and the vendored version works as expected.

@frol frol merged commit ca5c1ef into main Aug 15, 2024
6 checks passed
@frol frol deleted the fix/keyring branch August 15, 2024 14:25
@race-of-sloths
Copy link

🥁 Score it!

@frol, please ask your peers to score the PR using @race-of-sloths score [1/2/3/5/8/13].
If no scoring is provided within 24 hours, this PR will be scored as 1 🦥

@akorchyn
Copy link
Collaborator

@race-of-sloths score 3

FroVolod pushed a commit that referenced this pull request Aug 23, 2024
After a recent upgrade of keyring from 2.x to 3.x, all the features
became disabled by default instead of enabled by default, so we have to
enable them back again.
FroVolod pushed a commit that referenced this pull request Aug 23, 2024
After a recent upgrade of keyring from 2.x to 3.x, all the features
became disabled by default instead of enabled by default, so we have to
enable them back again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants