You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adapt JSON RPC responses so they return text old errors based on the new view client detailed errors (the structure and the messages must be IDENTICAL to the previous response messages); to do that we should match the structured error response received from the view client and craft the text of the old error message
This issue should be considered to be resolved once we can merge the proposed changes to the view-client (intorducing detailed programmatic errors instead of string errors), so any errornous response MUST remain the same:
We are going to expose those structured errors via RPC side-by-side with the current text errors as part of #2976. We do it in two steps to split the effort and take some time to bikeshed the structure we want to have for the RPC interfaces.
Implementation Notes
I propose to implement .to_old_error_message() -> String method for every error type we introduced for the view-client, so ultimately, on the jsonrpc side we can just call .to_old_error_message() on the ViewClientError and it would just recursively construct the error message for us.
The text was updated successfully, but these errors were encountered:
Rebase fix(rpc): structured errors #3204 to the latest master(moved into a separate issue Implement structured errors in view-client #3518)This issue should be considered to be resolved once we can merge the proposed changes to the view-client (intorducing detailed programmatic errors instead of string errors), so any errornous response MUST remain the same:
We are going to expose those structured errors via RPC side-by-side with the current text errors as part of #2976. We do it in two steps to split the effort and take some time to bikeshed the structure we want to have for the RPC interfaces.
Implementation Notes
I propose to implement
.to_old_error_message() -> String
method for every error type we introduced for the view-client, so ultimately, on thejsonrpc
side we can just call.to_old_error_message()
on theViewClientError
and it would just recursively construct the error message for us.The text was updated successfully, but these errors were encountered: