refactor(jsonrpc): Refactor view_client structured errors according to removal of BlockMissing for GetBlockError, GetChunkError, QueryError #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
force-pushed
the
refactor/structured-errors-view-client-jsonrpc-query-unknownblock
branch
from
13d33bb
to
2f8ff92
Compare
frol
approved these changes
Mar 11, 2021
bowenwang1996
approved these changes
Mar 11, 2021
khorolets
force-pushed
the
refactor/structured-errors-view-client-jsonrpc-query-unknownblock
branch
from
ef30002
to
3ec0603
Compare
…issing for GetBlockError, GetChunkError, QueryError
… from handle_query. Add @frol and @khorolets as codeowners for view_client.rs
khorolets
force-pushed
the
refactor/structured-errors-view-client-jsonrpc-query-unknownblock
branch
from
3ec0603
to
b4f86bc
Compare
frol
approved these changes
Mar 12, 2021
…nrpc-query-unknownblock
…nrpc-query-unknownblock
near-bulldozer
bot
deleted the
refactor/structured-errors-view-client-jsonrpc-query-unknownblock
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to recent removal of
BlockMissingwe had to refactor some structures to be up to date