-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: browser detect method for extension support #735
Conversation
v7.7.0 Release (dev -> main)
v7.8.0 Release (dev -> main)
v7.8.1 Release (dev -> main)
v7.8.2 Release (dev -> main)
v7.9.0 Release (dev -> main)
v7.9.1 Release (dev -> main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @daoauth thank you for submitting this PR.
support -> isSupported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will consider merging this after approval from @kujtimprenkuSQA
@hcho112 LGTM too, your approval was dismissed due to the base branch change since we needed to follow the flow for contributions: https://github.com/near/wallet-selector/blob/main/CONTRIBUTING.md#branching . Also had to update the description of the PR to include the Type of change checklist to make |
Description
Some browsers can't use chrome extension, so add detection method for support browser.
It was writted by referring to detect-browser, and test on 'safari', 'firefox', 'chrome', 'brave' and 'opera'.
@hcho112
Checklist:
Type of change.