Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: browser detect method for extension support #735

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

daoauth
Copy link
Contributor

@daoauth daoauth commented Mar 21, 2023

Description

Some browsers can't use chrome extension, so add detection method for support browser.

It was writted by referring to detect-browser, and test on 'safari', 'firefox', 'chrome', 'brave' and 'opera'.

@hcho112

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @daoauth thank you for submitting this PR.

support -> isSupported
hcho112
hcho112 previously approved these changes Mar 22, 2023
Copy link
Contributor

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will consider merging this after approval from @kujtimprenkuSQA

@kujtimprenkuSQA kujtimprenkuSQA changed the base branch from main to dev March 22, 2023 08:58
@kujtimprenkuSQA kujtimprenkuSQA dismissed hcho112’s stale review March 22, 2023 08:58

The base branch was changed.

@github-actions github-actions bot changed the title add: browser detect method for extension support feat: browser detect method for extension support Mar 22, 2023
@kujtimprenkuSQA
Copy link
Contributor

@hcho112 LGTM too, your approval was dismissed due to the base branch change since we needed to follow the flow for contributions: https://github.com/near/wallet-selector/blob/main/CONTRIBUTING.md#branching .

Also had to update the description of the PR to include the Type of change checklist to make gh-actions pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants