-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move the logic for detecting supported browsers for a wallet to core package #738
Merged
kujtimprenkuSQA
merged 6 commits into
dev
from
SQC-488/move-the-logic-for-detecting-supported-browsers-for-a-wallet-to-core-package
Mar 24, 2023
Merged
refactor: Move the logic for detecting supported browsers for a wallet to core package #738
kujtimprenkuSQA
merged 6 commits into
dev
from
SQC-488/move-the-logic-for-detecting-supported-browsers-for-a-wallet-to-core-package
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Move the logic for detecting supported browsers for a wallet to core package
refactor: Move the logic for detecting supported browsers for a wallet to core package
Mar 22, 2023
kujtimprenkuSQA
requested review from
hcho112,
DamirSQA,
amirsaran3 and
HarisSQA
March 22, 2023 15:52
DamirSQA
previously approved these changes
Mar 22, 2023
hcho112
reviewed
Mar 22, 2023
hcho112
reviewed
Mar 22, 2023
hcho112
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change request. In terms of name of the helper function, I'm open to suggestion as well.
DamirSQA
approved these changes
Mar 23, 2023
hcho112
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kujtimprenkuSQA
deleted the
SQC-488/move-the-logic-for-detecting-supported-browsers-for-a-wallet-to-core-package
branch
March 24, 2023 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about moving the logic for detecting the browser which an injected(extension) wallet supports to the
core
package so we can reuse it in other packages.The initial work was done as part of the previous PR: #735
This introduces a new helper function
isCurrentBrowserSupported
that accepts the list of browsers that a wallet supports, the goal is to show a wallet only on the browsers that is supported.The injected wallets will need to update the code to something like this in the setup function:
Checklist:
Type of change.