Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compare properties of Invalid types #1645

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

alex-savchuk
Copy link
Contributor

fix: compare properties of Invalid types #1643

@alex-savchuk alex-savchuk requested a review from a team as a code owner February 23, 2023 02:50
@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

@alex-savchuk this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Feb 23, 2023
@alex-savchuk
Copy link
Contributor Author

Problem was in processing of "github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name"
Both of these properties were not available -> comparison of values of "Invalid" type -> error is reported.

Fixed:

  • adding check for such situation and returning false when both compared values are Invalid (please confirm this assumption is correct)
  • Error texts are updated.
  • Test is updated.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1645 (9de011a) into master (4989f44) will increase coverage by 1.20%.
The diff coverage is 69.89%.

❗ Current head 9de011a differs from pull request most recent head ed26d4f. Consider uploading reports for the commit ed26d4f to get more accurate results

@@            Coverage Diff             @@
##           master    #1645      +/-   ##
==========================================
+ Coverage   61.22%   62.43%   +1.20%     
==========================================
  Files          46       48       +2     
  Lines        7141     7440     +299     
==========================================
+ Hits         4372     4645     +273     
- Misses       2462     2476      +14     
- Partials      307      319      +12     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/model/github_context.go 61.06% <32.00%> (-19.40%) ⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Feb 23, 2023
KnisterPeter
KnisterPeter previously approved these changes Feb 27, 2023
Copy link
Member

@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

I'm not blocking other maintainers to approve this for merging

pkg/exprparser/interpreter.go Outdated Show resolved Hide resolved
pkg/exprparser/interpreter.go Show resolved Hide resolved
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@mergify mergify bot merged commit 973dd7f into nektos:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants