Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't resize ensembles #703

Closed
studywolf opened this issue Mar 19, 2016 · 7 comments
Closed

can't resize ensembles #703

studywolf opened this issue Mar 19, 2016 · 7 comments

Comments

@studywolf
Copy link
Contributor

So on master of nengo_gui, when i start up nengo_gui I can't resize ensembles. When i got to the console it says

Uncaught TypeError: Cannot read property 'offsetX' of undefined : netgraph_item.js : 228

which is

 var w = pos[0] - event.clientX + this.ng.offsetX;

when i log this.ng to the console it's null...

@studywolf studywolf added the bug label Mar 19, 2016
@studywolf
Copy link
Contributor Author

seems to be fixed if you just drop the this

@studywolf
Copy link
Contributor Author

looks like it was changed waaay back in 02583f4 by @drasmuss , from screen_offset.

@tbekolay
Copy link
Member

I think the proper fix would be var self = this; ... self.ng.offsetX.

But also, this is useful feedback in that since the sprint no one who's on master has tried to resize ensembles until now ;)

@studywolf
Copy link
Contributor Author

yeah i was kind of shocked that no one has resized ensembles in the last
month and a half haha

On Sat, Mar 19, 2016 at 2:03 PM, Trevor Bekolay [email protected]
wrote:

I think the proper fix would be var self = this; ... self.ng.offsetX.

But also, this is useful feedback in that since the sprint no one who's on
master has tried to resize ensembles until now ;)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#703 (comment)

@studywolf
Copy link
Contributor Author

should all the other ng. ... references be changed to self.ng too?

@tbekolay
Copy link
Member

Looks like there are a mix of ng and self.ng in there yeah... probably either is fine, but best to be consistent. I'd go with self.ng, but either way!

@studywolf
Copy link
Contributor Author

alrighty, i'll update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants