Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#703 ensemble resizing #704

Merged
merged 2 commits into from
Mar 21, 2016
Merged

Fix#703 ensemble resizing #704

merged 2 commits into from
Mar 21, 2016

Conversation

studywolf
Copy link
Contributor

Fix for #703. Just dropping the this from the call to ng.

@tcstewar
Copy link
Collaborator

Just to check, what was your reasoning for the second commit here? The first commit seems to be the one that fixes the problem....

@tcstewar
Copy link
Collaborator

Just to check, what was your reasoning for the second commit here? The first commit seems to be the one that fixes the problem....

Ah, I see, @tbekolay recommended it for consistency. Cool!

@tbekolay
Copy link
Member

We discussed it in #703... it's just for consistency, as there was a mix of ng and self.ng in there.

@tcstewar
Copy link
Collaborator

Looks good to me... thanks for finding this....

tcstewar added a commit that referenced this pull request Mar 21, 2016
@tcstewar tcstewar merged commit 4750069 into master Mar 21, 2016
@tcstewar tcstewar deleted the fix_ensemble_resize branch March 21, 2016 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants