BUG: (9.0) User Workspace is null if first login to the site happens via "/neos/switch/to/..."

[grebaldi]

I found theEditorContentStreamZooKeeper to be responsible for creating user workspaces upon authentication when they do not exist yet.

For this purpose the relayEditorAuthentication method of EditorContentStreamZookeeper is registered as a signal handler for AuthenticationProviderManager::authenticatedToken:

neos-development-collection/Neos.Neos/Classes/Package.php

Lines 137 to 142 in 093cd64

	$dispatcher->connect(
	AuthenticationProviderManager::class,
	'authenticatedToken',
	EditorContentStreamZookeeper::class,
	'relayEditorAuthentication'
	);

If a user logs in via the form at /neos/login, this mechanism works perfectly.

In a multi-site setup however, the user may log in via /neos/login at site-a and then switches to site-b via the main menu by clicking on the link that leads to /neos/switch/to/site-b.

EditorContentStreamZooKeeper::relayEditorAuthentication does not capture this, so if the user doesn't have a user workspace at site-b already, it won't be created automatically in this case. The user is now trapped in an infinite redirect loop due to:
https://github.com/neos/neos-ui/blob/283a073b4b49ea20742067ef2d567516cabd9534/Classes/Controller/BackendController.php#L150-L156

I don't know what exactly needs to be fixed here. I looks to me as if LoginController::tokenLoginAction shouldn't cirumvent the AuthenticationProviderManager::authenticatedToken signal. But I have to admit that I have no idea what is supposed to happen here 😅

Related: #4590

[mhsdesign]

Same issue is when someone logged into neos before there was a site, and if afterwards a site will be created. The session is already authenticated so the zookeeper doesnt create a user workspace.

Currently the backend controller redirects to the login page https://github.com/neos/neos-ui/blob/369d27ab664d985b4f352eaabdc3b993719faa9c/Classes/Controller/BackendController.php#L155 in the hope that a user workspace will be created but, in reality we just crated a nice endless redirect loop.

To fix this i implemented the following instead of the redirect:

if (!$workspace) {
    // if a neos login session was active before the site was imported the EditorContentStreamZookeper was not able to create a user workspace. In that case we will do this here:
    $baseWorkspace = $contentRepository->getWorkspaceFinder()->findOneByName(WorkspaceName::forLive());
    if (!$baseWorkspace) {
        throw new NoHomepageException();
    }
    $editorsNewContentStreamId = ContentStreamId::create();
    $contentRepository->handle(
        CreateWorkspace::create(
            $workspaceName,
            $baseWorkspace->workspaceName,
            new WorkspaceTitle((string) $user->getName()),
            new WorkspaceDescription(''),
            $editorsNewContentStreamId,
            UserId::fromString($this->persistenceManager->getIdentifierByObject($user))
        )
    )->block();
    $workspace = $contentRepository->getWorkspaceFinder()->findOneByName(
        $workspaceName
    );
}

but what speaks against creating a workspace in the neos ui backend controller in general and remove the zookeeper?

---

tltr:

i want to create a user workspace only on demand directly in BackendController::indexAction is there a known flaw to this?
The zookeeper would only take care of removing workspaces if a user is deleted.

[bwaidelich]

This will hopefully resolved with #5146