!!! FEATURE: Extract workspace metadata and user-assignment to Neos #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `WorkspacePublishingService` as replacement for the current Neos `Workspace` "active record" model. Introduces `WorkspaceService` as central authority to manage Neos workspaces. Related: #4726
mhsdesign
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Some early thoughts thanks for the progress so far ❤️
Notes from my side:
- remove
\Neos\Neos\Domain\Service\UserService::deletePersonalWorkspaceand\Neos\Neos\Domain\Service\UserService::removeOwnerFromUsersWorkspaces - deprecate
\Neos\Neos\Service\UserService::getPersonalWorkspaceName - remove
WorkspaceNameBuilderagain
Neos.ContentRepositoryRegistry/Classes/ContentRepositoryRegistry.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/SharedModel/Workspace/WorkspaceName.php
Outdated
Show resolved
Hide resolved
bwaidelich
commented
Jun 18, 2024
Neos.ContentRepository.Core/Classes/SharedModel/Workspace/WorkspaceName.php
Outdated
Show resolved
Hide resolved
mhsdesign
reviewed
Jun 18, 2024
mhsdesign
reviewed
Jun 18, 2024
mhsdesign
reviewed
Jun 22, 2024
Neos.ContentRepositoryRegistry/Classes/ContentRepositoryRegistry.php
Outdated
Show resolved
Hide resolved
mhsdesign
reviewed
Jun 24, 2024
…ser-assignment-to-neos
…ser-assignment-to-neos
…ser-assignment-to-neos
bwaidelich
added a commit
that referenced
this pull request
Aug 2, 2024
Extracted from #5146 this just improves stability of the `WorkspaceName` value object by - Restricting the allowed value range to 30 lower case characters and properly enforce it - Adding a `tryFromString()` constructor - Exposing the `MAX_LENGTH` and use that for the corresponding database schemas - 100% test coverage Related: #4726
…ser-assignment-to-neos
bwaidelich
added a commit
to neos/neos-ui
that referenced
this pull request
Aug 9, 2024
…ser-assignment-to-neos
bwaidelich
commented
Sep 6, 2024
mhsdesign
reviewed
Sep 6, 2024
…ser-assignment-to-neos
and add initial behat tests
…orkspace-metadata-and-user-assignment-to-neos
Automatically set the current user as `Manager` and role `Neos.Neos:AbstractEditor` as `Collaborator` for new shared workspaces
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 8, 2024
mhsdesign
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Everything looks really good and perfectly thought out now thanks!
I also was able to remove the migration hack from the Neos ui e2e tests and use the assignRole command now.
The UI e2e tests mostly (except the flaky ones) pass and i just triggered one final run in the CI.
The Neos CI here is a bit kaput due to the Neos UI accidentally also being installed when testing and that crashes it due to a missing class and flow DI. See #4951
Locally phpstan and the CR behat tests pass which is IMO a good enough indicator. Post merge well see if were right *g
...and fix the discovered bugs along the way o.O
…ment-to-neos' of https://github.com/neos/neos-development-collection into feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
…ment-to-neos' of https://github.com/neos/neos-development-collection into feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
mhsdesign
deleted the
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
branch
mhsdesign
added a commit
to neos/neos-ui
that referenced
this pull request
Oct 9, 2024
* Draft: FEATURE: Extract workspace metadata and user-assignment to Neos Counter-part to neos/neos-development-collection#5146 * wip * WIP REVERT ME, PATCH E2E * Remove Neos UI `WorkspaceService` * Re-add UI WorkspaceService for now * Remove `WorkspaceNameBuilder` usages * TASK: Reintroduce usage of neos ui command value objects * Remove obsolete namespace import * WIP: Try to adjust e2e to work with new Neos workspace metadata * TASK: Remove `migrateWorkspaceMetadataToWorkspaceService` hack from e2e tests and use `assignrole` * Revert "WIP REVERT ME, PATCH E2E" This reverts commit 3aefeb2. --------- Co-authored-by: mhsdesign <[email protected]>
mhsdesign
restored the
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
branch
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 10, 2024
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Oct 10, 2024
Based on neos/neos-development-collection#5146 Required to ease migration to neos/neos-development-collection#5096
bwaidelich
added a commit
that referenced
this pull request
Oct 11, 2024
…e creation With #5146 a basic workspace access control was implemented. With that, users won't have access to workspaces unless they have a role assigned. This can be achieved via ```shell ./flow workspace:assignrole ``` This bugfix makes sure, that the default behavior (users with the role `Neos.Neos:LivePublisher` can collaborate on the `live` workspace) is automatically ensured when creating/importing a site. Furthermore, the migration command has been fixed to add metadata & role assignments even if no workspace title was set: ```shell ./flow migrateevents:migrateWorkspaceMetadataToWorkspaceService ``` Related: #4726
mhsdesign
deleted the
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
WorkspacePublishingServiceas replacement for the current NeosWorkspace"active record" model.Introduces
WorkspaceServiceas central authority to manage Neos workspaces.Migration
To migrate existing workspace metadata & roles, run
(The doctrine migrations definitely have to be executed before the first login!)
Related: #4726