-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define ContentGraph memory cache flushing #5039
Comments
points from todays meeting
|
WorkspaceRuntimeCache
and ContentSubgraphWithRuntimeCaches
after disabling
#4955
I think this issue is obsolete with #5243 and can be closed |
Yes was about to look this up when i read your issue but you found this already ^^ I believe the only thing that this covers also is the runtimeCache handling in the workspaceFinder which is not incorporated in your issue? |
That's right, but the workspace projection will be incorporated into the content graph projection anyways |
ahhh yes i forgot about that todo ;) so +1 |
In commit d57195d the cache invalidation was partly repaired But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246 A reintroduction will be discussed as part of another change. Related neos/neos-development-collection#5039
In commit c0ce2ba the cache invalidation was partly repaired But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246 A reintroduction will be discussed as part of another change. Related neos/neos-development-collection#5039
good point, this is a dealbreaker IMO – probably it makes sense to call this something else (e.g.
resetRuntimeCaches
) and then reset the inMemoryCache (we should not disable it).The main goal of this change was not to expose all those nasty internals such that we can refactor more easily.
In fact
inMemoryCache
is now only public because it is still used by the nasty code of the frontend controller (which I plan to clean up)But we should make sure that:
behaves as expected, i.e. the second subgraph interaction contains the changes.
Lets see if the tests fail – and if they don't we should add scenarios that reflect the above!
Originally posted by @bwaidelich in #5028 (comment)
The text was updated successfully, but these errors were encountered: