Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ContentGraph memory cache flushing #5039

Closed
mhsdesign opened this issue May 10, 2024 · 5 comments
Closed

Define ContentGraph memory cache flushing #5039

mhsdesign opened this issue May 10, 2024 · 5 comments
Labels

Comments

@mhsdesign
Copy link
Member

good point, this is a dealbreaker IMO – probably it makes sense to call this something else (e.g. resetRuntimeCaches) and then reset the inMemoryCache (we should not disable it).

The main goal of this change was not to expose all those nasty internals such that we can refactor more easily.
In fact inMemoryCache is now only public because it is still used by the nasty code of the frontend controller (which I plan to clean up)

But we should make sure that:

$subGraph->find*(...);
$contentRepository->handle(...);
$subGraph->find*(...);

behaves as expected, i.e. the second subgraph interaction contains the changes.

Lets see if the tests fail – and if they don't we should add scenarios that reflect the above!

Originally posted by @bwaidelich in #5028 (comment)

@mhsdesign
Copy link
Member Author

points from todays meeting

        * long running process where other process changes content repository? How to flush
            * manually call markstale??
        * flush in same process when mark stale
        * disable vs flush confusion?

@bwaidelich
Copy link
Member

I think this issue is obsolete with #5243 and can be closed

@mhsdesign
Copy link
Member Author

Yes was about to look this up when i read your issue but you found this already ^^

I believe the only thing that this covers also is the runtimeCache handling in the workspaceFinder which is not incorporated in your issue?

@bwaidelich
Copy link
Member

I believe the only thing that this covers also is the runtimeCache handling in the workspaceFinder which is not incorporated in your issue?

That's right, but the workspace projection will be incorporated into the content graph projection anyways

@mhsdesign
Copy link
Member Author

ahhh yes i forgot about that todo ;) so +1

@mhsdesign mhsdesign closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
mhsdesign added a commit that referenced this issue Oct 15, 2024
In commit 2a781d2 the cache invalidation was partly repaired
But as we removed the content graph cache layer currently in 9.0 #5246

A reintroduction will be discussed as part of another change.

Related #5039
neos-bot pushed a commit to neos/contentgraph-doctrinedbaladapter that referenced this issue Oct 18, 2024
In commit d57195d the cache invalidation was partly repaired
But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246

A reintroduction will be discussed as part of another change.

Related neos/neos-development-collection#5039
neos-bot pushed a commit to neos/contentrepository-core that referenced this issue Oct 18, 2024
In commit c0ce2ba the cache invalidation was partly repaired
But as we removed the content graph cache layer currently in 9.0 neos/neos-development-collection#5246

A reintroduction will be discussed as part of another change.

Related neos/neos-development-collection#5039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants